Skip to content

[v3-1-test] Change task log source display to hidden by default (#58749) #59045

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
pierrejeambrun merged 1 commit into from
Dec 4, 2025
Merged

[v3-1-test] Change task log source display to hidden by default (#58749) #59045

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
22 changes: 12 additions & 10 deletions airflow-core/src/airflow/ui/src/pages/TaskInstance/Logs/Logs.test.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -57,24 +57,26 @@ describe("Task log source", () => {
await waitForLogs();

let logLine = screen.getByTestId("virtualized-item-2");
const source = logLine.querySelector('[data-key="logger"]');
const loc = logLine.querySelector('[data-key="loc"]');

expect(source).toBeVisible();
expect(source).toHaveProperty("innerText", "source=airflow.models.dagbag.DagBag");

expect(loc).toBeVisible();
expect(loc).toHaveProperty("innerText", "loc=dagbag.py:593");
// Source should be hidden by default
expect(logLine.querySelector('[data-key="logger"]')).toBeNull();
expect(logLine.querySelector('[data-key="loc"]')).toBeNull();

// Toggle source on
fireEvent.keyDown(document.activeElement ?? document.body, { code: "KeyS", key: "S" });
fireEvent.keyPress(document.activeElement ?? document.body, { code: "KeyS", key: "S" });
fireEvent.keyUp(document.activeElement ?? document.body, { code: "KeyS", key: "S" });

logLine = screen.getByTestId("virtualized-item-2");
const source = logLine.querySelector('[data-key="logger"]');
const loc = logLine.querySelector('[data-key="loc"]');

// These should now find nothing
expect(logLine.querySelector('[data-key="logger"]')).toBeNull();
expect(logLine.querySelector('[data-key="loc"]')).toBeNull();
// Source should now be visible
expect(source).toBeVisible();
expect(source).toHaveProperty("innerText", "source=airflow.models.dagbag.DagBag");

expect(loc).toBeVisible();
expect(loc).toHaveProperty("innerText", "loc=dagbag.py:593");
});
});
describe("Task log grouping", () => {
Expand Down
2 changes: 1 addition & 1 deletion airflow-core/src/airflow/ui/src/pages/TaskInstance/Logs/Logs.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -81,7 +81,7 @@ export const Logs = () => {
"log_show_timestamp",
defaultShowTimestamp,
);
const [showSource, setShowSource] = useLocalStorage<boolean>("log_show_source", true);
const [showSource, setShowSource] = useLocalStorage<boolean>("log_show_source", false);
const [fullscreen, setFullscreen] = useState(false);
const [expanded, setExpanded] = useState(false);

Expand Down