-
Notifications
You must be signed in to change notification settings - Fork 16.3k
Fix DagRun.queued_at not updating when clearing #59066
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
1fanwang
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
thanks for the PR @ferruzzi , asked a question here just for my learning
Clearing a dag run sets the state to QUEUED so the scheduler will pick it up, but it did not reset the queued_at timestamp.
6771c52 to
d3d7c80
Compare
1fanwang
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Approved.
Thanks @ferruzzi — unit test looks good, and really appreciate the investigation and debugging here. This fix mitigates the issue and does exactly what it’s supposed to do.
Agreed that a full deep-dive into the underlying SQLAlchemy behavior is beyond the purpose and scope of this PR.
Should we create an issue to track this potential SQLAlchemy interaction so the community has it in the backlog to look into?
|
Nice investigation and questions :) |
Clearing a dag run sets the state to QUEUED so the scheduler will pick it up, but it did not reset the queued_at timestamp.
Clearing a dag run sets the state to QUEUED so the scheduler will pick it up, but it did not reset the queued_at timestamp.
^ Add meaningful description above
Read the Pull Request Guidelines for more information.
In case of fundamental code changes, an Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in a newsfragment file, named
{pr_number}.significant.rstor{issue_number}.significant.rst, in airflow-core/newsfragments.