Handle mid line chunking when writing docker stream to logs #59071
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
notatallshaw-gts
force-pushed
the
handle-mid-line-chunking-when-writing-docker-stream-to-logs
branch
2 times, most recently
from
a5525ab to
96b70fd
Compare
2 tasks
…8911) When when streaming logs from a Docker container the chunks that are sent back do not have to correspond to lines, there could be multiple chunks from a single line. We therefore have to handle buffering the output until we have a whole line to log, fixes apache#58911
notatallshaw-gts
force-pushed
the
handle-mid-line-chunking-when-writing-docker-stream-to-logs
branch
from
96b70fd to
1cfe9df
Compare
Contributor
Author
|
@potiuk This is very low priority, but if at some point in the future you could review or ping someone else more appropriate to review I would be very appreciative. I am running with this patch locally. |
amoghrajesh
pushed a commit
to astronomer/airflow
that referenced
this pull request
Dec 8, 2025
…9071) * Handle mid-line chunking when writing docker stream to logs (apache#58911) When when streaming logs from a Docker container the chunks that are sent back do not have to correspond to lines, there could be multiple chunks from a single line. We therefore have to handle buffering the output until we have a whole line to log, fixes apache#58911 * Add test for mid-line chunks and update existing tests to match correct expectations
52 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes: #58911
Prior PR that does not fully fix issue I am having: #43840