-
Notifications
You must be signed in to change notification settings - Fork 16.3k
Fix airflow/task-sdk relase PMC checks #59164
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There were few small issues with the airflow/task-sdk release-checks: * one cd was missing in the process * task-sdk folder was not pointing to the right sub-folder. * Dockerfile.pmc should use constraints and for task-sdk they should install also apache-airflow and apache-airflow-core as those are not dependencies of task-sdk and pip failed to find them without --pre flag.
jscheffl
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ah, more fixes, cool.
Did not notice the missing cd which is way better than another parameter added. Thanks for the additional fixes!
Release without a fix to the release process is an opportunity lost to improve things :) |
Backport failed to create: v3-1-test. View the failure log Run details
You can attempt to backport this manually by running: cherry_picker ad6961d v3-1-testThis should apply the commit to the v3-1-test branch and leave the commit in conflict state marking After you have resolved the conflicts, you can continue the backport process by running: cherry_picker --continue |
There were few small issues with the airflow/task-sdk release-checks: * one cd was missing in the process * task-sdk folder was not pointing to the right sub-folder. * Dockerfile.pmc should use constraints and for task-sdk they should install also apache-airflow and apache-airflow-core as those are not dependencies of task-sdk and pip failed to find them without --pre flag. (cherry picked from commit ad6961d) Co-authored-by: Jarek Potiuk <jarek@potiuk.com>
There were few small issues with the airflow/task-sdk release-checks: * one cd was missing in the process * task-sdk folder was not pointing to the right sub-folder. * Dockerfile.pmc should use constraints and for task-sdk they should install also apache-airflow and apache-airflow-core as those are not dependencies of task-sdk and pip failed to find them without --pre flag. (cherry picked from commit ad6961d)
There were few small issues with the airflow/task-sdk release-checks: * one cd was missing in the process * task-sdk folder was not pointing to the right sub-folder. * Dockerfile.pmc should use constraints and for task-sdk they should install also apache-airflow and apache-airflow-core as those are not dependencies of task-sdk and pip failed to find them without --pre flag.
There were few small issues with the airflow/task-sdk release-checks: * one cd was missing in the process * task-sdk folder was not pointing to the right sub-folder. * Dockerfile.pmc should use constraints and for task-sdk they should install also apache-airflow and apache-airflow-core as those are not dependencies of task-sdk and pip failed to find them without --pre flag. (cherry picked from commit ad6961d)
There were few small issues with the airflow/task-sdk release-checks: * one cd was missing in the process * task-sdk folder was not pointing to the right sub-folder. * Dockerfile.pmc should use constraints and for task-sdk they should install also apache-airflow and apache-airflow-core as those are not dependencies of task-sdk and pip failed to find them without --pre flag. (cherry picked from commit ad6961d)
There were few small issues with the airflow/task-sdk release-checks: * one cd was missing in the process * task-sdk folder was not pointing to the right sub-folder. * Dockerfile.pmc should use constraints and for task-sdk they should install also apache-airflow and apache-airflow-core as those are not dependencies of task-sdk and pip failed to find them without --pre flag. (cherry picked from commit ad6961d)
There were few small issues with the airflow/task-sdk release-checks: * one cd was missing in the process * task-sdk folder was not pointing to the right sub-folder. * Dockerfile.pmc should use constraints and for task-sdk they should install also apache-airflow and apache-airflow-core as those are not dependencies of task-sdk and pip failed to find them without --pre flag. (cherry picked from commit ad6961d)
There were few small issues with the airflow/task-sdk release-checks: * one cd was missing in the process * task-sdk folder was not pointing to the right sub-folder. * Dockerfile.pmc should use constraints and for task-sdk they should install also apache-airflow and apache-airflow-core as those are not dependencies of task-sdk and pip failed to find them without --pre flag. (cherry picked from commit ad6961d)
There were few small issues with the airflow/task-sdk release-checks: * one cd was missing in the process * task-sdk folder was not pointing to the right sub-folder. * Dockerfile.pmc should use constraints and for task-sdk they should install also apache-airflow and apache-airflow-core as those are not dependencies of task-sdk and pip failed to find them without --pre flag. (cherry picked from commit ad6961d)
There were few small issues with the airflow/task-sdk release-checks: * one cd was missing in the process * task-sdk folder was not pointing to the right sub-folder. * Dockerfile.pmc should use constraints and for task-sdk they should install also apache-airflow and apache-airflow-core as those are not dependencies of task-sdk and pip failed to find them without --pre flag. (cherry picked from commit ad6961d)
There were few small issues with the airflow/task-sdk release-checks: * one cd was missing in the process * task-sdk folder was not pointing to the right sub-folder. * Dockerfile.pmc should use constraints and for task-sdk they should install also apache-airflow and apache-airflow-core as those are not dependencies of task-sdk and pip failed to find them without --pre flag. (cherry picked from commit ad6961d)
There were few small issues with the airflow/task-sdk release-checks: * one cd was missing in the process * task-sdk folder was not pointing to the right sub-folder. * Dockerfile.pmc should use constraints and for task-sdk they should install also apache-airflow and apache-airflow-core as those are not dependencies of task-sdk and pip failed to find them without --pre flag. (cherry picked from commit ad6961d)

There were few small issues with the airflow/task-sdk release-checks:
^ Add meaningful description above
Read the Pull Request Guidelines for more information.
In case of fundamental code changes, an Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in a newsfragment file, named
{pr_number}.significant.rstor{issue_number}.significant.rst, in airflow-core/newsfragments.