Skip to content

Conversation

@potiuk
Copy link
Member

@potiuk potiuk commented Dec 8, 2025

After discussion in urllib3/urllib3#3731 maintainers of urllib3 decided to restore the removed getheaders() method for now. We should change < to !=.


^ Add meaningful description above
Read the Pull Request Guidelines for more information.
In case of fundamental code changes, an Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in a newsfragment file, named {pr_number}.significant.rst or {issue_number}.significant.rst, in airflow-core/newsfragments.

After discussion in urllib3/urllib3#3731
maintainers of urllib3 decided to restore the removed getheaders()
method for now. We should change < to !=.
@boring-cyborg boring-cyborg bot added area:API Airflow's REST/HTTP API area:kubernetes-tests area:providers provider:cncf-kubernetes Kubernetes (k8s) provider related issues labels Dec 8, 2025
@potiuk potiuk added this to the Airflow 3.1.4 milestone Dec 8, 2025
@potiuk potiuk added the backport-to-v3-1-test Mark PR with this label to backport to v3-1-test branch label Dec 8, 2025
@potiuk potiuk merged commit dd31202 into apache:main Dec 8, 2025
90 of 91 checks passed
@potiuk potiuk deleted the convert-urllib3-exclusion-to-non-equal branch December 8, 2025 16:18
@potiuk
Copy link
Member Author

potiuk commented Dec 8, 2025

All good - the error was accidental. Also:

image

@github-actions
Copy link

github-actions bot commented Dec 8, 2025

Backport failed to create: v3-1-test. View the failure log Run details

Status Branch Result
v3-1-test Commit Link

You can attempt to backport this manually by running:

cherry_picker dd31202 v3-1-test

This should apply the commit to the v3-1-test branch and leave the commit in conflict state marking
the files that need manual conflict resolution.

After you have resolved the conflicts, you can continue the backport process by running:

cherry_picker --continue

potiuk added a commit to potiuk/airflow that referenced this pull request Dec 8, 2025
…59203)

After discussion in urllib3/urllib3#3731
maintainers of urllib3 decided to restore the removed getheaders()
method for now. We should change < to !=.
(cherry picked from commit dd31202)

Co-authored-by: Jarek Potiuk <jarek@potiuk.com>
potiuk added a commit to potiuk/airflow that referenced this pull request Dec 8, 2025
…59203)

After discussion in urllib3/urllib3#3731
maintainers of urllib3 decided to restore the removed getheaders()
method for now. We should change < to !=.
(cherry picked from commit dd31202)

Co-authored-by: Jarek Potiuk <jarek@potiuk.com>
potiuk added a commit to potiuk/airflow that referenced this pull request Dec 8, 2025
After discussion in urllib3/urllib3#3731
maintainers of urllib3 decided to restore the removed getheaders()
method for now. We should change < to !=.

(cherry picked from commit dd31202)
potiuk added a commit that referenced this pull request Dec 8, 2025
After discussion in urllib3/urllib3#3731
maintainers of urllib3 decided to restore the removed getheaders()
method for now. We should change < to !=.

(cherry picked from commit dd31202)
@potiuk
Copy link
Member Author

potiuk commented Dec 8, 2025

Backported to #59212

ephraimbuddy pushed a commit that referenced this pull request Dec 9, 2025
After discussion in urllib3/urllib3#3731
maintainers of urllib3 decided to restore the removed getheaders()
method for now. We should change < to !=.

(cherry picked from commit dd31202)
henry3260 pushed a commit to henry3260/airflow that referenced this pull request Dec 10, 2025
After discussion in urllib3/urllib3#3731
maintainers of urllib3 decided to restore the removed getheaders()
method for now. We should change < to !=.
ephraimbuddy pushed a commit that referenced this pull request Dec 11, 2025
After discussion in urllib3/urllib3#3731
maintainers of urllib3 decided to restore the removed getheaders()
method for now. We should change < to !=.

(cherry picked from commit dd31202)
ephraimbuddy pushed a commit that referenced this pull request Dec 12, 2025
After discussion in urllib3/urllib3#3731
maintainers of urllib3 decided to restore the removed getheaders()
method for now. We should change < to !=.

(cherry picked from commit dd31202)
ephraimbuddy pushed a commit that referenced this pull request Jan 6, 2026
After discussion in urllib3/urllib3#3731
maintainers of urllib3 decided to restore the removed getheaders()
method for now. We should change < to !=.

(cherry picked from commit dd31202)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area:API Airflow's REST/HTTP API area:kubernetes-tests area:providers backport-to-v3-1-test Mark PR with this label to backport to v3-1-test branch provider:cncf-kubernetes Kubernetes (k8s) provider related issues

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants