-
Notifications
You must be signed in to change notification settings - Fork 16.3k
issue-59189: Updating Databricks provider to point to 2.2/jobs/... endpoint
#59217
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
Including comment from issue. I've created a draft PR to upgrade to API v2.2 for all I have a few questions for @jscheffl and @eladkal:
|
Now that I see the PR (besides the comments I made on the issue) I think it is straight forward to upgrade all endpoints to 2.2 consistently. |
Yep. |
|
Sounds good, I'll go ahead and update all of those endpoints. |
|
@eladkal, do you know the folks who maintain the Databricks provider? I'd love to get their review on this. |
There is - currently - no dedicated people to review providers - we we want to introduce it as a way to track it - see https://lists.apache.org/thread/jqjd801g9161dqyv7l2xbsw0v7mp77z1 but it has not happened yet. Your best guess is to look at git history for the provider |
|
Thanks, @potiuk. |
jscheffl
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Let's do a final rebase and then LGTM in my view.
f9acde0 to
1e5b8f1
Compare
…` endpoint (apache#59217) * issue-59189: Updating Databricks provider to point to 2.2/jobs/... endpoint * issue-59189: Updating docs to point towards 2.1/jobs to 2.2/jobs * issue-59189: Moving other API endpoints to 2.2
…` endpoint (apache#59217) * issue-59189: Updating Databricks provider to point to 2.2/jobs/... endpoint * issue-59189: Updating docs to point towards 2.1/jobs to 2.2/jobs * issue-59189: Moving other API endpoints to 2.2
| LIST_SQL_ENDPOINTS_ENDPOINT = ("GET", "2.0/sql/endpoints") | ||
| LIST_JOBS_ENDPOINT = ("GET", "2.2/jobs/list") | ||
| LIST_PIPELINES_ENDPOINT = ("GET", "2.2/pipelines") | ||
| LIST_SQL_ENDPOINTS_ENDPOINT = ("GET", "2.2/sql/endpoints") |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This endpoint unfortunately does not exist and I even do think that has been migrated to: https://docs.databricks.com/api/workspace/warehouses/list
[2026-01-13 03:32:41] ERROR - Task failed with exception source=task loc=task_runner.py:986
AirflowException: Response: {"error":"Bad Target: /api/2.2/sql/endpoints"}
, Status Code: 404
HTTPError: 404 Client Error: Not Found for url: https://dbc-instance-random.cloud.databricks.com/api/2.2/sql/endpoints
File "/home/airflow/.local/lib/python3.12/site-packages/airflow/providers/databricks/hooks/databricks_base.py", line 704 in _do_api_call
File "/home/airflow/.local/lib/python3.12/site-packages/tenacity/__init__.py", line 445 in __iter__
File "/home/airflow/.local/lib/python3.12/site-packages/tenacity/__init__.py", line 378 in iter
File "/home/airflow/.local/lib/python3.12/site-packages/tenacity/__init__.py", line 400 in <lambda>
File "/usr/python/lib/python3.12/concurrent/futures/_base.py", line 449 in result
File "/usr/python/lib/python3.12/concurrent/futures/_base.py", line 401 in __get_result
File "/home/airflow/.local/lib/python3.12/site-packages/airflow/providers/databricks/hooks/databricks_base.py", line 723 in _do_api_call
File "/home/airflow/.local/lib/python3.12/site-packages/requests/models.py", line 1026 in raise_for_status
Previous version api/2.0/sql/endpoints works is there even though is not listed in the Databricks documentation.
|
Hi! Apart of updating jobs api path to Previous version Latest Databricks docs does not even include Maybe that’s just me but when doing API version bumps I would expect to bump a minor version not a fix version number. Should latest databricks provider version be yanked? |
|
@aru-trackunit can you raise a quick fix?
If the fix partially works I am not sure we can yank it as there are users who might already using the rest of the functionality. We normally yank if the release is completely invalid. |
|
Created this: #60444, I see that there are others raising missing endpoints comments, #59189 (comment) |
|
@aru-trackunit if you know what the problem and what is the needed fix you can just go a head and create a PR with the fix. There is a planned release for later today so if the fix is merge before it will be included |
|
I am cutting providers wave already, so too late now. As the bug is already released I assume a fix would be great for the next providers wave in 2 weeks. Except it we judge urgent and we cut a special RC2 for this. |
Description
The
apache-airflow-providers-databricksprovider uses API version2.1for alljobsoperations. This PR bumps that API version to2.2for alljobsoperations. These changes were made in three places:Hooks/Operatorstests...related: #59189