Upgrade SQLAlchemy (SQLA) to 2.0 #59218
Merged
+353
−124
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Dev-iL
changed the title
vincbeck
force-pushed
the
vincbeck/fab_remove_sqla_limit
branch
from
17dec44 to
f3cc8f8
Compare
vincbeck
requested review from
amoghrajesh,
ashb,
bugraoz93,
gopidesupavan,
jason810496,
jscheffl,
kaxil,
potiuk and
vincbeck
as code owners
Dev-iL
force-pushed
the
Dev-iL/sqla2_deadlock
branch
from
5ce5e2e to
084d78f
Compare
vincbeck
added
full tests needed
Dev-iL
force-pushed
the
Dev-iL/sqla2_deadlock
branch
7 times, most recently
from
0a11b78 to
a410faf
Compare
Dev-iL
force-pushed
the
Dev-iL/sqla2_deadlock
branch
from
7112da5 to
20def2f
Compare
Dev-iL
force-pushed
the
Dev-iL/sqla2_deadlock
branch
from
20def2f to
438246b
Compare
potiuk
approved these changes
Dec 29, 2025
Member
potiuk
left a comment
potiuk
left a comment
There was a problem hiding this comment.
LGTM - but I think at least @vincbeck review will be needed as well - possibly few other people who are more into SQLA.
Also - the DISCUSS thread is overwhelmingly "let's drop SQLA1" as expected, I propose @Dev-iL you start a LAZY CONSENSUS thread and link to this PR - this will drag attention of more maintainers.
Subham-KRLX
pushed a commit
to Subham-KRLX/airflow
that referenced
this pull request
Jan 2, 2026
Related: apache#59218, apache#59402 Passes mypy & pre-commit checks airflow-core/src/airflow/api_fastapi airflow-core/tests/unit/api_fastapi/execution_api/versions/head/test_dag_runs.py. airflow-core/tests/unit/api_fastapi/execution_api/versions/head/test_variables.py airflow-core/tests/unit/api_fastapi/execution_api/versions/head/test_xcoms.py
Dev-iL
force-pushed
the
Dev-iL/sqla2_deadlock
branch
from
438246b to
0c069eb
Compare
Collaborator
Author
|
Lazy consensus passed. I guess we're waiting for @vincbeck's blessing now... |
Collaborator
Author
|
Interestingly, after the latest rebase, several deps get downgraded: < cadwyn==6.0.0
> cadwyn==5.4.6
< fastapi==0.128.0
> fastapi==0.117.1
< starlette==0.50.0
> starlette==0.48.0 |
Contributor
I think @jscheffl wrote something about it in the cicd channel on slack, where the pipeline got dependency conflicts on Arm, maybe it can help him. Here is the slack message: |
Dev-iL
force-pushed
the
Dev-iL/sqla2_deadlock
branch
2 times, most recently
from
6549cb9 to
1c84f22
Compare
jscheffl
force-pushed
the
Dev-iL/sqla2_deadlock
branch
from
1c84f22 to
887dad6
Compare
Contributor
|
For safety made a final rebase, let's have CI green and then merge ASAP! |
This was referenced Jan 5, 2026
Closed
Contributor
|
#protm |
chirodip98
pushed a commit
to chirodip98/airflow-contrib
that referenced
this pull request
Jan 9, 2026
* Remove SQLA 1 limit in Fab provider * Simplify the SQLA debug logging * Modify session start/end and release metadata locks * Address Nataneljpwd's comments * Address copilot's comments --------- Co-authored-by: vincbeck <vincbeck@amazon.com>
stegololz
pushed a commit
to stegololz/airflow
that referenced
this pull request
Jan 9, 2026
Related: apache#59218, apache#59402 Passes mypy & pre-commit checks airflow-core/src/airflow/api_fastapi airflow-core/tests/unit/api_fastapi/execution_api/versions/head/test_dag_runs.py. airflow-core/tests/unit/api_fastapi/execution_api/versions/head/test_variables.py airflow-core/tests/unit/api_fastapi/execution_api/versions/head/test_xcoms.py
stegololz
pushed a commit
to stegololz/airflow
that referenced
this pull request
Jan 9, 2026
* Remove SQLA 1 limit in Fab provider * Simplify the SQLA debug logging * Modify session start/end and release metadata locks * Address Nataneljpwd's comments * Address copilot's comments --------- Co-authored-by: vincbeck <vincbeck@amazon.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
related: #28723, #58049
Fixing assorted issues preventing us from removing the SQLA1.4 limitation. Note that many fixes done as part of this effort were split into standalone PRs as can be seen in this PR's history below.
^ Add meaningful description above
Read the Pull Request Guidelines for more information.
In case of fundamental code changes, an Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in a newsfragment file, named
{pr_number}.significant.rstor{issue_number}.significant.rst, in airflow-core/newsfragments.