Skip to content

Prevent Concurrent TaskInstance Tries in Scheduler HA #59234

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
pdellarciprete wants to merge 4 commits into from
Closed

Prevent Concurrent TaskInstance Tries in Scheduler HA #59234

Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
81923b1
explicitly exclude tasks that are already in the `SCHEDULED` state in…
pdellarciprete Dec 9, 2025
929518e
change where condition
pdellarciprete Dec 13, 2025
87f6c00
fix where condition to include null cases
pdellarciprete Dec 14, 2025
0256413
fix pre-commit check
pdellarciprete Dec 15, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions airflow-core/src/airflow/models/dagrun.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -119,6 +119,9 @@

log = structlog.get_logger(__name__)

# Create a set without None for the IN clause
NON_NULL_SCHEDULABLE_STATES = SCHEDULEABLE_STATES - {None}


class TISchedulingDecision(NamedTuple):
"""Type of return for DagRun.task_instance_scheduling_decisions."""
Expand Down Expand Up @@ -2081,6 +2084,7 @@ def schedule_tis(
result = session.execute(
update(TI)
.where(TI.id.in_(id_chunk))
.where(or_(TI.state.is_(None), TI.state.in_(NON_NULL_SCHEDULABLE_STATES)))
.values(
state=TaskInstanceState.SCHEDULED,
scheduled_dttm=timezone.utcnow(),
Expand Down