[v3-1-test] Fix an odd import of pendulum from sqlalchemy_utils instead of elsewhere. (#59258) #59265
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ad of elsewhere. (#59258) This was likely a case of auto-complete gone wrong. Most of the time this doesn't matter (as SQLa etc is already loaded) but this was importing it in Task SDK mistakenly which we don't want. Interestingly mypy now "noticed" that `pendulum.parse` can return Duration, Date, and Time objects too. I don't know why it didn't notice this before. Also generally this isn't the right import :) (cherry picked from commit 0b6d258) Co-authored-by: Ash Berlin-Taylor <ash@apache.org>
ashb
approved these changes
Dec 10, 2025
ephraimbuddy
pushed a commit
that referenced
this pull request
Dec 11, 2025
…ad of elsewhere. (#59258) (#59265) This was likely a case of auto-complete gone wrong. Most of the time this doesn't matter (as SQLa etc is already loaded) but this was importing it in Task SDK mistakenly which we don't want. Interestingly mypy now "noticed" that `pendulum.parse` can return Duration, Date, and Time objects too. I don't know why it didn't notice this before. Also generally this isn't the right import :) (cherry picked from commit 0b6d258) Co-authored-by: Ash Berlin-Taylor <ash@apache.org>
ephraimbuddy
pushed a commit
that referenced
this pull request
Dec 12, 2025
…ad of elsewhere. (#59258) (#59265) This was likely a case of auto-complete gone wrong. Most of the time this doesn't matter (as SQLa etc is already loaded) but this was importing it in Task SDK mistakenly which we don't want. Interestingly mypy now "noticed" that `pendulum.parse` can return Duration, Date, and Time objects too. I don't know why it didn't notice this before. Also generally this isn't the right import :) (cherry picked from commit 0b6d258) Co-authored-by: Ash Berlin-Taylor <ash@apache.org>
ephraimbuddy
pushed a commit
that referenced
this pull request
Jan 6, 2026
…ad of elsewhere. (#59258) (#59265) This was likely a case of auto-complete gone wrong. Most of the time this doesn't matter (as SQLa etc is already loaded) but this was importing it in Task SDK mistakenly which we don't want. Interestingly mypy now "noticed" that `pendulum.parse` can return Duration, Date, and Time objects too. I don't know why it didn't notice this before. Also generally this isn't the right import :) (cherry picked from commit 0b6d258) Co-authored-by: Ash Berlin-Taylor <ash@apache.org>
61 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This was likely a case of auto-complete gone wrong. Most of the time this
doesn't matter (as SQLa etc is already loaded) but this was importing it in
Task SDK mistakenly which we don't want.
Interestingly mypy now "noticed" that
pendulum.parsecan returnDuration, Date, and Time objects too. I don't know why it didn't notice this
before.
Also generally this isn't the right import :)
(cherry picked from commit 0b6d258)
Co-authored-by: Ash Berlin-Taylor ash@apache.org