Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Original file line number Diff line number Diff line change
Expand Up @@ -36,7 +36,8 @@
class _KubernetesCmdDecoratedOperator(DecoratedOperator, KubernetesPodOperator):
custom_operator_name = "@task.kubernetes_cmd"

template_fields: Sequence[str] = KubernetesPodOperator.template_fields
template_fields: Sequence[str] = tuple({"op_args", "op_kwargs", *KubernetesPodOperator.template_fields})

overwrite_rtif_after_execution: bool = True

def __init__(self, *, python_callable: Callable, args_only: bool = False, **kwargs) -> None:
Expand Down Expand Up @@ -69,6 +70,8 @@ def __init__(self, *, python_callable: Callable, args_only: bool = False, **kwar
)

def execute(self, context: Context):
self.render_template_fields(context)

generated = self._generate_cmds(context)
if self.args_only:
self.cmds = []
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -397,3 +397,26 @@ def hello():
self.execute_task(hello_task)
self.mock_hook.assert_not_called()
self.mock_create_pod.assert_not_called()

def test_kubernetes_cmd_template_fields_include_taskflow_args(self):
"""Test that kubernetes_cmd operator has op_args and op_kwargs in template_fields"""
with self.dag_maker:

@task.kubernetes_cmd(
image="python:3.10-slim-buster",
in_cluster=False,
cluster_context="default",
config_file="/tmp/fake_file",
namespace="default",
)
def hello(name: str) -> list[str]:
return ["echo", name]

hello_task = hello("world")

op = hello_task.operator

assert "op_args" in op.template_fields
assert "op_kwargs" in op.template_fields
assert "cmds" in op.template_fields
assert "arguments" in op.template_fields