Skip to content

Fix: Null key reference in bigquery cursor query results #53127 #59343

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
potiuk merged 2 commits into from
Dec 11, 2025
Merged

Fix: Null key reference in bigquery cursor query results #53127 #59343

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
f9223cb
Fix _format_schema_for_description to handle missing "fields" key gra…
baaaqt Dec 11, 2025
1241f6c
Merge branch 'main' into fix/keyerror-gcp-53127
baaaqt Dec 11, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
25 changes: 13 additions & 12 deletions providers/google/src/airflow/providers/google/cloud/hooks/bigquery.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1990,18 +1990,19 @@ def _format_schema_for_description(schema: dict) -> list:
internal_size, precision, scale, null_ok.
"""
description = []
for field in schema["fields"]:
mode = field.get("mode", "NULLABLE")
field_description = (
field["name"],
field["type"],
None,
None,
None,
None,
mode == "NULLABLE",
)
description.append(field_description)
if "fields" in schema:
for field in schema["fields"]:
mode = field.get("mode", "NULLABLE")
field_description = (
field["name"],
field["type"],
None,
None,
None,
None,
mode == "NULLABLE",
)
description.append(field_description)
return description


Expand Down
5 changes: 5 additions & 0 deletions providers/google/tests/unit/google/cloud/hooks/test_bigquery.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1043,6 +1043,11 @@ def test_format_schema_for_description(self):
("field_3", "STRING", None, None, None, None, False),
]

def test_format_schema_for_description_no_fields_key(self):
test_query_result = {"schema": {}}
description = _format_schema_for_description(test_query_result["schema"])
assert description == []

@mock.patch("airflow.providers.google.cloud.hooks.bigquery.build")
@mock.patch("airflow.providers.google.cloud.hooks.bigquery.BigQueryHook.insert_job")
def test_description(self, mock_insert, mock_build):
Expand Down
Loading