Skip to content

Adaptions for custom auth manager example in documentation #59355

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
vincbeck merged 3 commits into from
Dec 16, 2025
Merged

Adaptions for custom auth manager example in documentation #59355

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
787a304
Allow skipping of session ID rotation when using OAuth in auth manager
wolfdn Dec 11, 2025
4bdae65
Remove login_user function from custom auth manager example
wolfdn Dec 12, 2025
b1e3bac
Merge remote-tracking branch 'origin/main' into feature/allow-skippin…
wolfdn Dec 16, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 1 addition & 5 deletions providers/fab/docs/auth-manager/token.rst
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -144,16 +144,12 @@ This custom logic overrides the default ``create_token`` method from the FAB aut
"role_keys": groups,
}

user = self.security_manager.auth_user_oauth(userinfo)
user = self.security_manager.auth_user_oauth(userinfo, rotate_session_id=False)

# Fall back to the default implementation
else:
user = super().create_token(headers=headers, body=body)

log.info("User: %s", user)

# Log user into the session
if user is not None:
login_user(user, remember=False)

return user
5 changes: 3 additions & 2 deletions providers/fab/src/airflow/providers/fab/auth_manager/security_manager/override.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2019,7 +2019,7 @@ def get_oauth_token_secret_name(self, provider):
if _provider["name"] == provider:
return _provider.get("token_secret", "oauth_token_secret")

def auth_user_oauth(self, userinfo):
def auth_user_oauth(self, userinfo, rotate_session_id=True):
"""
Authenticate user with OAuth.

Expand Down Expand Up @@ -2073,7 +2073,8 @@ def auth_user_oauth(self, userinfo):

# LOGIN SUCCESS (only if user is now registered)
if user:
self._rotate_session_id()
if rotate_session_id:
self._rotate_session_id()
self.update_user_auth_stat(user)
return user
return None
Expand Down