-
Notifications
You must be signed in to change notification settings - Fork 16.3k
Add missing fields to SQLValueCheckOperator docstring #59409
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add missing fields to SQLValueCheckOperator docstring #59409
Conversation
|
Congratulations on your first Pull Request and welcome to the Apache Airflow community! If you have any issues or are unsure about any anything please check our Contributors' Guide (https://github.com/apache/airflow/blob/main/contributing-docs/README.rst)
|
|
@goldfish088 - nice work! The issue also mentioned adding docs for the usage of this Operator? Would you be interested in adding those docs as part of this PR? |
|
Hi @jroachgolf84, yes I am interested.
Update: My PR is ready for review. |
691ab6e to
ea283f7
Compare
930908f to
7e0c0ef
Compare
7e0c0ef to
0d816ff
Compare
0d816ff to
616c98a
Compare
|
@potiuk Is this PR all good to merge? I noticed that there was an error in a workflow run with one of the CI actions failing with status 502 when fetching |
|
Infra hiccups I guess |
|
Awesome work, congrats on your first merged pull request! You are invited to check our Issue Tracker for additional contributions. |
* Add missing pass_value and tolerance fields to SQLValueCheckOperator docstring (apache#59377) * Add example usage for SQLValueCheckOperator in the docs
Adds descriptions of the missing
pass_valueandtolerancefields in the docstring ofSQLValueCheckOperator.Closes: #59377