Skip to content

Conversation

@goldfish088
Copy link
Contributor

Adds descriptions of the missing pass_value and tolerance fields in the docstring of SQLValueCheckOperator.

Closes: #59377

@boring-cyborg
Copy link

boring-cyborg bot commented Dec 14, 2025

Congratulations on your first Pull Request and welcome to the Apache Airflow community! If you have any issues or are unsure about any anything please check our Contributors' Guide (https://github.com/apache/airflow/blob/main/contributing-docs/README.rst)
Here are some useful points:

  • Pay attention to the quality of your code (ruff, mypy and type annotations). Our prek-hooks will help you with that.
  • In case of a new feature add useful documentation (in docstrings or in docs/ directory). Adding a new operator? Check this short guide Consider adding an example DAG that shows how users should use it.
  • Consider using Breeze environment for testing locally, it's a heavy docker but it ships with a working Airflow and a lot of integrations.
  • Be patient and persistent. It might take some time to get a review or get the final approval from Committers.
  • Please follow ASF Code of Conduct for all communication including (but not limited to) comments on Pull Requests, Mailing list and Slack.
  • Be sure to read the Airflow Coding style.
  • Always keep your Pull Requests rebased, otherwise your build might fail due to changes not related to your commits.
    Apache Airflow is a community-driven project and together we are making it better 🚀.
    In case of doubts contact the developers at:
    Mailing List: dev@airflow.apache.org
    Slack: https://s.apache.org/airflow-slack

@goldfish088 goldfish088 changed the title Add missing fields to SQLValueCheckOperator docstring (#59377) Add missing fields to SQLValueCheckOperator docstring Dec 14, 2025
@jroachgolf84
Copy link
Collaborator

@goldfish088 - nice work! The issue also mentioned adding docs for the usage of this Operator? Would you be interested in adding those docs as part of this PR?

@goldfish088
Copy link
Contributor Author

goldfish088 commented Dec 16, 2025

Hi @jroachgolf84, yes I am interested.

I do not know how to add the docs for using this Operator, but I will study how it is done for other Operators and make an attempt. Any pointers are appreciated!

Update: My PR is ready for review.

@goldfish088 goldfish088 force-pushed the docs/sql-value-check-operator branch 5 times, most recently from 691ab6e to ea283f7 Compare December 16, 2025 12:03
@goldfish088 goldfish088 force-pushed the docs/sql-value-check-operator branch 2 times, most recently from 930908f to 7e0c0ef Compare December 16, 2025 13:52
@goldfish088 goldfish088 force-pushed the docs/sql-value-check-operator branch from 7e0c0ef to 0d816ff Compare December 16, 2025 22:01
@goldfish088 goldfish088 force-pushed the docs/sql-value-check-operator branch from 0d816ff to 616c98a Compare December 17, 2025 06:33
@goldfish088
Copy link
Contributor Author

goldfish088 commented Dec 17, 2025

@potiuk Is this PR all good to merge? I noticed that there was an error in a workflow run with one of the CI actions failing with status 502 when fetching uv.

@potiuk
Copy link
Member

potiuk commented Dec 17, 2025

Infra hiccups I guess

@potiuk potiuk merged commit f8d1e88 into apache:main Dec 17, 2025
86 checks passed
@boring-cyborg
Copy link

boring-cyborg bot commented Dec 17, 2025

Awesome work, congrats on your first merged pull request! You are invited to check our Issue Tracker for additional contributions.

Lohith625 pushed a commit to Lohith625/airflow that referenced this pull request Dec 19, 2025
* Add missing pass_value and tolerance fields to SQLValueCheckOperator docstring (apache#59377)

* Add example usage for SQLValueCheckOperator in the docs
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

SQLValueCheckOperator params incorrect & missing docs

3 participants