Skip to content

Refactor test_timestamp.py to use SQLA2 #59420

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
choo121600 wants to merge 4 commits into from
Closed

Refactor test_timestamp.py to use SQLA2 #59420

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
df66515
Refactor test_timestamp.py to use SQLA2
choo121600 Dec 15, 2025
1c86ddf
Fix regex pattern in pre-commit
choo121600 Dec 15, 2025
9def75b
Merge branch 'main' into refactor/sqla2-test-timestamp
choo121600 Dec 15, 2025
647503a
Merge branch 'main' into refactor/sqla2-test-timestamp
choo121600 Dec 16, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions .pre-commit-config.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -413,6 +413,7 @@ repos:
^airflow-ctl.*\.py$|
^airflow-core/src/airflow/models/.*\.py$|
^airflow-core/tests/unit/api_fastapi/core_api/routes/public/test_assets.py$|
^airflow-core/tests/unit/models/test_timestamp.py$|
^dev/airflow_perf/scheduler_dag_execution_timing.py$|
^providers/openlineage/.*\.py$|
^task_sdk.*\.py$
Expand Down
5 changes: 3 additions & 2 deletions airflow-core/tests/unit/models/test_timestamp.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -19,6 +19,7 @@
import pendulum
import pytest
import time_machine
from sqlalchemy import select

from airflow._shared.timezones import timezone
from airflow.models import Log
Expand Down Expand Up @@ -60,7 +61,7 @@ def test_timestamp_behaviour(dag_maker, session):
current_time = timezone.utcnow()
old_log = add_log(execdate, session, dag_maker)
session.expunge(old_log)
log_time = session.query(Log).one().dttm
log_time = session.scalars(select(Log)).one().dttm
assert log_time == current_time
assert log_time.tzinfo.name == "UTC"

Expand All @@ -73,7 +74,7 @@ def test_timestamp_behaviour_with_timezone(dag_maker, session):
old_log = add_log(execdate, session, dag_maker, timezone_override=pendulum.timezone("Europe/Warsaw"))
session.expunge(old_log)
# No matter what timezone we set - we should always get back UTC
log_time = session.query(Log).one().dttm
log_time = session.scalars(select(Log)).one().dttm
assert log_time == current_time
assert old_log.dttm.tzinfo.name != "UTC"
assert log_time.tzinfo.name == "UTC"
Expand Down