Skip to content

Refactor deprecated SQLA models/test_pool.py #59439

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
rich7420 wants to merge 3 commits into from
Closed

Refactor deprecated SQLA models/test_pool.py #59439

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
ef4e7e1
Refactor deprecated SQLA models/test_pool.py
rich7420 Dec 15, 2025
3b974f1
Merge branch 'main' into sqla2-59-2
rich7420 Dec 16, 2025
5120909
Merge branch 'main' into sqla2-59-2
rich7420 Dec 17, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions .pre-commit-config.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -425,6 +425,7 @@ repos:
^airflow-ctl.*\.py$|
^airflow-core/src/airflow/models/.*\.py$|
^airflow-core/tests/unit/api_fastapi/core_api/routes/public/test_assets.py$|
^airflow-core/tests/unit/models/test_pool.py$|
^airflow-core/tests/unit/utils/test_db_cleanup.py$|
^dev/airflow_perf/scheduler_dag_execution_timing.py$|
^providers/openlineage/.*\.py$|
Expand Down
7 changes: 4 additions & 3 deletions airflow-core/tests/unit/models/test_pool.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -21,6 +21,7 @@

import pendulum
import pytest
from sqlalchemy import func, select

from airflow import settings
from airflow.exceptions import AirflowException, PoolNotFound
Expand Down Expand Up @@ -292,7 +293,7 @@ def test_create_pool(self, session):
assert pool.slots == 5
assert pool.description == ""
assert pool.include_deferred is True
assert session.query(Pool).count() == self.TOTAL_POOL_COUNT + 1
assert session.scalar(select(func.count()).select_from(Pool)) == self.TOTAL_POOL_COUNT + 1

def test_create_pool_existing(self, session):
self.add_pools()
Expand All @@ -303,13 +304,13 @@ def test_create_pool_existing(self, session):
assert pool.slots == 5
assert pool.description == ""
assert pool.include_deferred is False
assert session.query(Pool).count() == self.TOTAL_POOL_COUNT
assert session.scalar(select(func.count()).select_from(Pool)) == self.TOTAL_POOL_COUNT

def test_delete_pool(self, session):
self.add_pools()
pool = Pool.delete_pool(name=self.pools[-1].pool)
assert pool.pool == self.pools[-1].pool
assert session.query(Pool).count() == self.TOTAL_POOL_COUNT - 1
assert session.scalar(select(func.count()).select_from(Pool)) == self.TOTAL_POOL_COUNT - 1

def test_delete_pool_non_existing(self):
with pytest.raises(PoolNotFound, match="^Pool 'test' doesn't exist$"):
Expand Down