Skip to content

Refactor deprecated SQLA query mysql provider #59444

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
choo121600 wants to merge 1 commit into from
Closed

Refactor deprecated SQLA query mysql provider #59444

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions .pre-commit-config.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -413,6 +413,7 @@ repos:
^airflow-ctl.*\.py$|
^airflow-core/src/airflow/models/.*\.py$|
^airflow-core/tests/unit/api_fastapi/core_api/routes/public/test_assets.py$|
^providers/mysql/.*\.py$|
^task_sdk.*\.py$
pass_filenames: true
- id: update-supported-versions
Expand Down
8 changes: 3 additions & 5 deletions providers/mysql/tests/unit/mysql/transfers/test_s3_to_mysql.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -19,7 +19,7 @@
from unittest.mock import patch

import pytest
from sqlalchemy import or_
from sqlalchemy import delete, or_

from airflow import models
from airflow.providers.mysql.transfers.s3_to_mysql import S3ToMySqlOperator
Expand Down Expand Up @@ -101,10 +101,8 @@ def test_execute_exception(self, mock_remove, mock_bulk_load_custom, mock_downlo

def teardown_method(self):
with create_session() as session:
(
session.query(models.Connection)
.filter(
session.execute(
delete(models.Connection).where(
or_(models.Connection.conn_id == "s3_test", models.Connection.conn_id == "mysql_test")
)
.delete()
)