Skip to content

Refactor deprecated SQLA test_log_handlers.py #59458

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
rich7420 wants to merge 2 commits into from
Closed

Refactor deprecated SQLA test_log_handlers.py #59458

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
f78fec3
Refactor deprecated SQLA test_log_handlers.py
rich7420 Dec 15, 2025
da6dcd5
Merge branch 'main' into sqla2-59402-9
rich7420 Dec 17, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions .pre-commit-config.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -425,6 +425,7 @@ repos:
^airflow-ctl.*\.py$|
^airflow-core/src/airflow/models/.*\.py$|
^airflow-core/tests/unit/api_fastapi/core_api/routes/public/test_assets.py$|
^airflow-core/tests/unit/utils/test_log_handlers.py$|
^airflow-core/tests/unit/utils/test_db_cleanup.py$|
^dev/airflow_perf/scheduler_dag_execution_timing.py$|
^providers/openlineage/.*\.py$|
Expand Down
22 changes: 11 additions & 11 deletions airflow-core/tests/unit/utils/test_log_handlers.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -36,6 +36,7 @@
from pydantic import TypeAdapter
from pydantic.v1.utils import deep_update
from requests.adapters import Response
from sqlalchemy import delete, select

from airflow import settings
from airflow.config_templates.airflow_local_settings import DEFAULT_LOGGING_CONFIG
Expand Down Expand Up @@ -98,8 +99,9 @@ def cleanup_tables():
class TestFileTaskLogHandler:
def clean_up(self):
with create_session() as session:
session.query(DagRun).delete()
session.query(TaskInstance).delete()
session.execute(delete(DagRun))
session.execute(delete(TaskInstance))
session.commit()

def setup_method(self):
settings.configure_logging()
Expand Down Expand Up @@ -781,16 +783,14 @@ def test_jinja_id_in_template_for_history(
)
TaskInstanceHistory.record_ti(ti, session=session)
session.flush()
tih = (
session.query(TaskInstanceHistory)
.filter_by(
dag_id=ti.dag_id,
task_id=ti.task_id,
run_id=ti.run_id,
map_index=ti.map_index,
try_number=ti.try_number,
tih = session.scalar(
select(TaskInstanceHistory).where(
TaskInstanceHistory.dag_id == ti.dag_id,
TaskInstanceHistory.task_id == ti.task_id,
TaskInstanceHistory.run_id == ti.run_id,
TaskInstanceHistory.map_index == ti.map_index,
TaskInstanceHistory.try_number == ti.try_number,
)
.one()
)
fth = FileTaskHandler("")
rendered_ti = fth._render_filename(ti, ti.try_number, session=session)
Expand Down
Loading