Skip to content

Conversation

@bugraoz93
Copy link
Contributor

related: #59466

  • It seems the newer version of pnpm does not contain the default in the virtual prek environment
  • Ran the hook fixing FieldSelector.tsx and Code.tsx

^ Add meaningful description above
Read the Pull Request Guidelines for more information.
In case of fundamental code changes, an Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in a newsfragment file, named {pr_number}.significant.rst or {issue_number}.significant.rst, in airflow-core/newsfragments.

- Newer version of pnpm not contain default in virtual prek environment
- Ran the hook fixing FieldSelector.tsx and Code.tsx
@boring-cyborg boring-cyborg bot added the area:UI Related to UI/UX. For Frontend Developers. label Dec 15, 2025
@bugraoz93
Copy link
Contributor Author

Seems this also missing adding as well @typescript-eslint/utils

@bugraoz93 bugraoz93 changed the title Add @typescript-eslint/eslint-plugin version 8.50.0 to dependencies Add @typescript-eslint dev dependencies for version 8.50.0 Dec 15, 2025
@bugraoz93 bugraoz93 merged commit c4b1759 into apache:main Dec 15, 2025
64 checks passed
@bugraoz93 bugraoz93 deleted the add-ts-eslint-plugin-dep branch December 15, 2025 23:01
@bugraoz93
Copy link
Contributor Author

Passed here merged. Thanks for reviews! :)
https://github.com/apache/airflow/actions/runs/20249567908/job/58138933824

@bbovenzi
Copy link
Contributor

Thanks for catching this. I had it in another PR but it got bogged down

FoxHelms pushed a commit to FoxHelms/airflow that referenced this pull request Dec 17, 2025
)

* Add @typescript-eslint/eslint-plugin version 8.50.0 to dependencies

- Newer version of pnpm not contain default in virtual prek environment
- Ran the hook fixing FieldSelector.tsx and Code.tsx

* Add @typescript-eslint/utils version 8.50.0 to dependencies

* Add @typescript-eslint/parser version 8.50.0 to dependencies
pierrejeambrun pushed a commit to astronomer/airflow that referenced this pull request Dec 18, 2025
)

* Add @typescript-eslint/eslint-plugin version 8.50.0 to dependencies

- Newer version of pnpm not contain default in virtual prek environment
- Ran the hook fixing FieldSelector.tsx and Code.tsx

* Add @typescript-eslint/utils version 8.50.0 to dependencies

* Add @typescript-eslint/parser version 8.50.0 to dependencies

(cherry picked from commit c4b1759)
@pierrejeambrun
Copy link
Member

Manual backport #59601

pierrejeambrun pushed a commit to astronomer/airflow that referenced this pull request Dec 18, 2025
)

* Add @typescript-eslint/eslint-plugin version 8.50.0 to dependencies

- Newer version of pnpm not contain default in virtual prek environment
- Ran the hook fixing FieldSelector.tsx and Code.tsx

* Add @typescript-eslint/utils version 8.50.0 to dependencies

* Add @typescript-eslint/parser version 8.50.0 to dependencies

(cherry picked from commit c4b1759)
pierrejeambrun added a commit that referenced this pull request Dec 18, 2025
…59601)

* Add @typescript-eslint/eslint-plugin version 8.50.0 to dependencies

- Newer version of pnpm not contain default in virtual prek environment
- Ran the hook fixing FieldSelector.tsx and Code.tsx

* Add @typescript-eslint/utils version 8.50.0 to dependencies

* Add @typescript-eslint/parser version 8.50.0 to dependencies

(cherry picked from commit c4b1759)

Co-authored-by: Bugra Ozturk <bugraoz93@users.noreply.github.com>
@bugraoz93
Copy link
Contributor Author

I assumed I made the backport for this. Thanks a lot Pierre! Totally missed to backport

TempestShaw pushed a commit to TempestShaw/airflow that referenced this pull request Dec 24, 2025
)

* Add @typescript-eslint/eslint-plugin version 8.50.0 to dependencies

- Newer version of pnpm not contain default in virtual prek environment
- Ran the hook fixing FieldSelector.tsx and Code.tsx

* Add @typescript-eslint/utils version 8.50.0 to dependencies

* Add @typescript-eslint/parser version 8.50.0 to dependencies
ephraimbuddy pushed a commit that referenced this pull request Jan 6, 2026
…59601)

* Add @typescript-eslint/eslint-plugin version 8.50.0 to dependencies

- Newer version of pnpm not contain default in virtual prek environment
- Ran the hook fixing FieldSelector.tsx and Code.tsx

* Add @typescript-eslint/utils version 8.50.0 to dependencies

* Add @typescript-eslint/parser version 8.50.0 to dependencies

(cherry picked from commit c4b1759)

Co-authored-by: Bugra Ozturk <bugraoz93@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area:UI Related to UI/UX. For Frontend Developers.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants