-
Notifications
You must be signed in to change notification settings - Fork 16.3k
Add result_backend_transport_options for Redis Sentinel support in Celery #59498
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
Congratulations on your first Pull Request and welcome to the Apache Airflow community! If you have any issues or are unsure about any anything please check our Contributors' Guide (https://github.com/apache/airflow/blob/main/contributing-docs/README.rst)
|
|
@potiuk could you please help review this PR when you get a chance? |
|
static checks to fix |
|
@potiuk @hussein-awala please help me rerun those workflows, made more changes to fix workflow errors |
|
Awesome work, congrats on your first merged pull request! You are invited to check our Issue Tracker for additional contributions. |
…lery (apache#59498) * Add result_backend_transport_options for Redis Sentinel support in Celery * Fix language check * Fix static checks * Added info
…lery (apache#59498) * Add result_backend_transport_options for Redis Sentinel support in Celery * Fix language check * Fix static checks * Added info
…lery (apache#59498) * Add result_backend_transport_options for Redis Sentinel support in Celery * Fix language check * Fix static checks * Added info
Currently, Airflow only supports Redis Sentinel for the Celery broker via [celery_broker_transport_options]. This PR adds the equivalent [celery_result_backend_transport_options] section to support Redis Sentinel as the result backend, including sentinel_kwargs and master_name configuration options.
With these changes i was able to use redis sentinel for result_backend for celery.
^ Add meaningful description above
Read the Pull Request Guidelines for more information.
In case of fundamental code changes, an Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in a newsfragment file, named
{pr_number}.significant.rstor{issue_number}.significant.rst, in airflow-core/newsfragments.