-
Notifications
You must be signed in to change notification settings - Fork 16.3k
Refactor/sqla2 multiple files #59540
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
# Conflicts: # .pre-commit-config.yaml
# Conflicts: # .pre-commit-config.yaml
# Conflicts: # .pre-commit-config.yaml
# Conflicts: # .pre-commit-config.yaml
# Conflicts: # .pre-commit-config.yaml
# Conflicts: # .pre-commit-config.yaml
# Conflicts: # .pre-commit-config.yaml
# Conflicts: # .pre-commit-config.yaml
choo121600
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM :)
|
@choo121600 thanks! |
henry3260
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good!!
|
Rebase plus conflict resolving and we should be good :) |
|
It’s resolved now~ |
|
I resolved conflict this time :) |
Backport failed to create: v3-1-test. View the failure log Run details
You can attempt to backport this manually by running: cherry_picker 75b2b7d v3-1-testThis should apply the commit to the v3-1-test branch and leave the commit in conflict state marking After you have resolved the conflicts, you can continue the backport process by running: cherry_picker --continue |
|
thanks @potiuk , @uranusjr , @choo121600 , @henry3260 and @Prab-27 for the review! |
* Refactor deprecated SQLA models/test_serialized_dag.py * Refactor deprecated SQLA models/test_pool.py * Refactor deprecated SQLA models/test_trigger.py * Refactor deprecated SQLA models/test_callback.py * Refactor deprecated SQLA models/test_xcom.py * Refactor deprecated SQLA models/test_cleartasks.py * Refactor deprecated SQLA models/test_dagrun.py * Refactor deprecated SQLA test_log_handlers.py * fix error * Refactor deprecated SQLA utils/test_state.py * fix error * remove redundant parts * change to where() * fix pre-commit error * fix error * remove redundant commit() --------- Co-authored-by: Jarek Potiuk <jarek@potiuk.com>
related: #59402
composed of:
models/test_serialized_dag.py #59437
models/test_pool.py #59439
models/test_trigger.py #59440
models/test_callback.py #59442
models/test_xcom.py #59443
models/test_cleartasks.py #59447
models/test_dagrun.py #59450
test_log_handlers.py #59458
utils/test_state.py #59461
^ Add meaningful description above
Read the Pull Request Guidelines for more information.
In case of fundamental code changes, an Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in a newsfragment file, named
{pr_number}.significant.rstor{issue_number}.significant.rst, in airflow-core/newsfragments.