Skip to content

[v3-1-test] Add log record when listening dag is partitioned but run has no key (#59375) #59582

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
potiuk merged 1 commit into from
Dec 17, 2025
Merged

[v3-1-test] Add log record when listening dag is partitioned but run has no key (#59375) #59582

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 5 additions & 1 deletion airflow-core/src/airflow/assets/manager.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -134,7 +134,11 @@ def register_asset_change(
)
)
if not asset_model:
cls.logger().warning("AssetModel %s not found", asset)
msg = f"AssetModel {asset} not found; cannot create asset event."
cls.logger().warning(msg)
# if there is a task_instance, write to task log
if task_instance is not None and hasattr(task_instance, "log"):
task_instance.log.warning(msg)
return None

if not asset_model.active:
Expand Down
2 changes: 2 additions & 0 deletions airflow-core/tests/unit/assets/test_manager.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -69,6 +69,7 @@ def create_mock_dag():

class TestAssetManager:
def test_register_asset_change_asset_doesnt_exist(self, mock_task_instance):
mock_task_instance = mock.Mock()
asset = Asset(uri="asset_doesnt_exist", name="not exist")

mock_session = mock.Mock(spec=Session)
Expand All @@ -84,6 +85,7 @@ def test_register_asset_change_asset_doesnt_exist(self, mock_task_instance):
# AssetDagRunQueue rows
mock_session.add.assert_not_called()
mock_session.merge.assert_not_called()
mock_task_instance.log.warning.assert_called()

def test_register_asset_change(self, session, dag_maker, mock_task_instance, testing_dag_bundle):
asset_manager = AssetManager()
Expand Down
Loading