Skip to content

Conversation

@potiuk
Copy link
Member

@potiuk potiuk commented Dec 20, 2025

Follow up after #59658 - there are few more places where canary builds used pip check and until the pip inconsistent behaviour is fixed (pypa/pip#13709) we should use uv pip check instead.


^ Add meaningful description above
Read the Pull Request Guidelines for more information.
In case of fundamental code changes, an Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in a newsfragment file, named {pr_number}.significant.rst or {issue_number}.significant.rst, in airflow-core/newsfragments.

Follow up after apache#59658 - there are few more places where canary
builds used `pip check` and until the `pip` inconsistent behaviour
is fixed (pypa/pip#13709) we should use
`uv pip check` instead.
@boring-cyborg boring-cyborg bot added area:dev-tools area:production-image Production image improvements and fixes backport-to-v3-1-test Mark PR with this label to backport to v3-1-test branch labels Dec 20, 2025
@potiuk potiuk added this to the Airflow 3.1.6 milestone Dec 20, 2025
@kaxil kaxil merged commit 33e6d3e into apache:main Dec 20, 2025
128 checks passed
kaxil pushed a commit to astronomer/airflow that referenced this pull request Dec 20, 2025
Follow up after apache#59658 - there are few more places where canary
builds used `pip check` and until the `pip` inconsistent behaviour
is fixed (pypa/pip#13709) we should use
`uv pip check` instead.

(cherry picked from commit 33e6d3e)
@github-actions
Copy link

Backport failed to create: v3-1-test. View the failure log Run details

Status Branch Result
v3-1-test Commit Link

You can attempt to backport this manually by running:

cherry_picker 33e6d3e v3-1-test

This should apply the commit to the v3-1-test branch and leave the commit in conflict state marking
the files that need manual conflict resolution.

After you have resolved the conflicts, you can continue the backport process by running:

cherry_picker --continue

@potiuk
Copy link
Member Author

potiuk commented Dec 20, 2025

The real issue (as explained by pip maintainer is that pagefind has wrongly prepared metadata - and the pip maintainer was kind enough to open a PR in pagefind to fix it: Pagefind/pagefind#989 -> pip check is sensitive to such issues.

Subham-KRLX pushed a commit to Subham-KRLX/airflow that referenced this pull request Jan 2, 2026
Follow up after apache#59658 - there are few more places where canary
builds used `pip check` and until the `pip` inconsistent behaviour
is fixed (pypa/pip#13709) we should use
`uv pip check` instead.
ephraimbuddy pushed a commit that referenced this pull request Jan 6, 2026
Follow up after #59658 - there are few more places where canary
builds used `pip check` and until the `pip` inconsistent behaviour
is fixed (pypa/pip#13709) we should use
`uv pip check` instead.

(cherry picked from commit 33e6d3e)
stegololz pushed a commit to stegololz/airflow that referenced this pull request Jan 9, 2026
Follow up after apache#59658 - there are few more places where canary
builds used `pip check` and until the `pip` inconsistent behaviour
is fixed (pypa/pip#13709) we should use
`uv pip check` instead.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area:dev-tools area:production-image Production image improvements and fixes backport-to-v3-1-test Mark PR with this label to backport to v3-1-test branch

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants