Add Content-Type to Request Header in Task SDK calls, fix logic #59676
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jscheffl
added
the
backport-to-v3-1-test
jscheffl
force-pushed
the
bugfix/add-content-type-to-task-sdk-calls-v2
branch
from
defacbc to
fa712ba
Compare
ephraimbuddy
approved these changes
Dec 21, 2025
Backport successfully created: v3-1-test
|
Subham-KRLX
pushed a commit
to Subham-KRLX/airflow
that referenced
this pull request
Jan 2, 2026
stegololz
pushed a commit
to stegololz/airflow
that referenced
this pull request
Jan 9, 2026
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
After we deployed Airflow 3.1.5 to our environment @AutomationDev85 and me noticed that still the WAF rules hit the deployment and debugging one level deeper revealed a logic problem of the fix applied in #57377:
The call from base class
patch()to the extendedClientfrom TaskSDK uses actually (empty) kwargs for content and header (e.g. passingcontent=Noneandheader=Nonewhich then made the header not applied. See also https://github.com/encode/httpx/blob/master/httpx/_client.py#L1221This PR corrects the logic to check for "if any content is to be submitted" and "No header for content type set". With this the content-type header is now consistently applied making our WAF happy.