-
Notifications
You must be signed in to change notification settings - Fork 16.3k
Draft: Provider documentation URL handling for custom providers #59677
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Add TODO comment for provider documentation URL handling
|
Congratulations on your first Pull Request and welcome to the Apache Airflow community! If you have any issues or are unsure about any anything please check our Contributors' Guide (https://github.com/apache/airflow/blob/main/contributing-docs/README.rst)
|
|
I’ve opened a draft PR to start working on this and to coordinate on the approach. |
Allow Providers UI to link to custom provider documentation URLs when provided, with fallback to default Airflow docs.
|
@shubhdevelops, there are a few things missing in this PR. As a learning experience, check out my PR (#59584) to see the additional changes that were needed for this. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the contribution!
there are a few things missing in this PR. As a learning experience, check out my PR (#59584) to see the additional changes that were needed for this.
Yes, we still need to change the ProviderManager and backend API as well, so sorry that we might need to close this PR.
|
Sorry again for closing this PR, as #59584 already implemented the same feature. I appreciate your contribution. |
Draft PR to start work on allowing custom providers to define their own documentation URLs.
Related issue: #59576
This PR currently only adds a TODO marker in the UI code to highlight where
provider-specific documentation URLs should be handled.
No functional changes yet. This draft is meant for coordination and early feedback.
^ Add meaningful description above
Read the Pull Request Guidelines for more information.
In case of fundamental code changes, an Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in a newsfragment file, named
{pr_number}.significant.rstor{issue_number}.significant.rst, in airflow-core/newsfragments.