Backport changes for dix test_date_timezone_omitted by patching correct timezone attribute. (#59698) #59702
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sunank200
added
the
full tests needed
amoghrajesh
approved these changes
Dec 22, 2025
…apache#59698) The test was failing because it tried to patch a non-existent TIMEZONE attribute. The timezone module uses _Timezone.initialized_timezone to store the default timezone, which is what the parse function uses when parsing timestamps without timezone information. Fixes failing tests: - TestCLIDBClean.test_date_timezone_omitted[UTC] - TestCLIDBClean.test_date_timezone_omitted[Europe/Berlin] - TestCLIDBClean.test_date_timezone_omitted[America/Los_Angeles] (cherry picked from commit 3d33d6d)
sunank200
force-pushed
the
backport-3d33d6d-v3-1-test
branch
from
226c803 to
df77264
Compare
Lee-W
approved these changes
Dec 22, 2025
Collaborator
Author
|
This can be closed because the original PR #59689 was not backported to this branch. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The test was failing because it tried to patch a non-existent TIMEZONE attribute. The timezone module uses _Timezone.initialized_timezone to store the default timezone, which is what the parse function uses when parsing timestamps without timezone information.
(cherry picked from commit 3d33d6d)
^ Add meaningful description above
Read the Pull Request Guidelines for more information.
In case of fundamental code changes, an Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in a newsfragment file, named
{pr_number}.significant.rstor{issue_number}.significant.rst, in airflow-core/newsfragments.