Skip to content

Replace imports from airflow.security.permissions module in fab provider due to future deprecation of the module. #59755

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
potiuk merged 1 commit into from
Dec 27, 2025
+13 −10
Merged

Replace imports from airflow.security.permissions module in fab provider due to future deprecation of the module. #59755

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 6 additions & 2 deletions providers/fab/src/airflow/providers/fab/auth_manager/cli_commands/permissions_command.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -50,7 +50,11 @@ def cleanup_dag_permissions(dag_id: str, session: Session = NEW_SESSION) -> None
from sqlalchemy import delete, select

from airflow.providers.fab.auth_manager.models import Permission, Resource, assoc_permission_role
from airflow.security.permissions import RESOURCE_DAG_PREFIX, RESOURCE_DAG_RUN, RESOURCE_DETAILS_MAP
from airflow.providers.fab.www.security.permissions import (
RESOURCE_DAG_PREFIX,
RESOURCE_DAG_RUN,
RESOURCE_DETAILS_MAP,
)

# Clean up specific DAG permissions
dag_resources = session.scalars(
Expand Down Expand Up @@ -107,7 +111,7 @@ def permissions_cleanup(args):
from airflow.models import DagModel
from airflow.providers.fab.auth_manager.cli_commands.utils import get_application_builder
from airflow.providers.fab.auth_manager.models import Resource
from airflow.security.permissions import (
from airflow.providers.fab.www.security.permissions import (
RESOURCE_DAG_PREFIX,
RESOURCE_DAG_RUN,
RESOURCE_DETAILS_MAP,
Expand Down
9 changes: 4 additions & 5 deletions providers/fab/src/airflow/providers/fab/auth_manager/security_manager/override.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -101,7 +101,6 @@
from airflow.providers.fab.www.security import permissions
from airflow.providers.fab.www.security_manager import AirflowSecurityManagerV2
from airflow.providers.fab.www.session import AirflowDatabaseSessionInterface
from airflow.security.permissions import RESOURCE_BACKFILL

if TYPE_CHECKING:
from airflow.providers.fab.www.security.permissions import (
Expand Down Expand Up @@ -236,7 +235,7 @@ class FabAirflowSecurityManagerOverride(AirflowSecurityManagerV2):
(permissions.ACTION_CAN_READ, permissions.RESOURCE_DAG_WARNING),
(permissions.ACTION_CAN_READ, RESOURCE_ASSET),
(permissions.ACTION_CAN_READ, RESOURCE_ASSET_ALIAS),
(permissions.ACTION_CAN_READ, RESOURCE_BACKFILL),
(permissions.ACTION_CAN_READ, permissions.RESOURCE_BACKFILL),
(permissions.ACTION_CAN_READ, permissions.RESOURCE_CLUSTER_ACTIVITY),
(permissions.ACTION_CAN_READ, permissions.RESOURCE_POOL),
(permissions.ACTION_CAN_READ, permissions.RESOURCE_IMPORT_ERROR),
Expand Down Expand Up @@ -308,9 +307,9 @@ class FabAirflowSecurityManagerOverride(AirflowSecurityManagerV2):
(permissions.ACTION_CAN_DELETE, permissions.RESOURCE_XCOM),
(permissions.ACTION_CAN_CREATE, RESOURCE_ASSET),
(permissions.ACTION_CAN_DELETE, RESOURCE_ASSET),
(permissions.ACTION_CAN_CREATE, RESOURCE_BACKFILL),
(permissions.ACTION_CAN_EDIT, RESOURCE_BACKFILL),
(permissions.ACTION_CAN_DELETE, RESOURCE_BACKFILL),
(permissions.ACTION_CAN_CREATE, permissions.RESOURCE_BACKFILL),
(permissions.ACTION_CAN_EDIT, permissions.RESOURCE_BACKFILL),
(permissions.ACTION_CAN_DELETE, permissions.RESOURCE_BACKFILL),
]
# [END security_op_perms]

Expand Down
6 changes: 3 additions & 3 deletions providers/fab/tests/unit/fab/auth_manager/cli_commands/test_permissions_command.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -256,7 +256,7 @@ def test_cleanup_dag_permissions_removes_specific_dag_resources(self):
cleanup_dag_permissions,
)
from airflow.providers.fab.auth_manager.models import Action, Permission, Resource
from airflow.security.permissions import RESOURCE_DAG_PREFIX
from airflow.providers.fab.www.security.permissions import RESOURCE_DAG_PREFIX
from airflow.utils.session import create_session

with create_session() as session:
Expand Down Expand Up @@ -309,7 +309,7 @@ def test_cleanup_dag_permissions_handles_resources_without_permissions(self):
cleanup_dag_permissions,
)
from airflow.providers.fab.auth_manager.models import Resource
from airflow.security.permissions import RESOURCE_DAG_PREFIX
from airflow.providers.fab.www.security.permissions import RESOURCE_DAG_PREFIX
from airflow.utils.session import create_session

with create_session() as session:
Expand All @@ -330,7 +330,7 @@ def test_cleanup_dag_permissions_with_default_session(self):
cleanup_dag_permissions,
)
from airflow.providers.fab.auth_manager.models import Resource
from airflow.security.permissions import RESOURCE_DAG_PREFIX
from airflow.providers.fab.www.security.permissions import RESOURCE_DAG_PREFIX
from airflow.utils.session import create_session

# Setup test data
Expand Down