Skip to content

Conversation

@KamranImaaz
Copy link
Contributor

@KamranImaaz KamranImaaz commented Dec 28, 2025

Description:

Updated the Depricated field(Project_id) in alignment and format of Google Provider.

Updated the log/info message: Ignoring deprecated 'project_id' parameter because 'table_project_id' is provided.

Verified that all relevant unit tests for BigQueryGetDataOperator pass.

Impact:

Provides clear deprecation warnings for users following the new table_project_id parameter.

Maintains backward compatibility while encouraging migration to the updated parameter.

Testing:

Ran pytest for BigQueryGetDataOperator tests.

All synchronous tests passed; async tests skipped (fixture not available locally).

@boring-cyborg
Copy link

boring-cyborg bot commented Dec 28, 2025

Congratulations on your first Pull Request and welcome to the Apache Airflow community! If you have any issues or are unsure about any anything please check our Contributors' Guide (https://github.com/apache/airflow/blob/main/contributing-docs/README.rst)
Here are some useful points:

  • Pay attention to the quality of your code (ruff, mypy and type annotations). Our prek-hooks will help you with that.
  • In case of a new feature add useful documentation (in docstrings or in docs/ directory). Adding a new operator? Check this short guide Consider adding an example DAG that shows how users should use it.
  • Consider using Breeze environment for testing locally, it's a heavy docker but it ships with a working Airflow and a lot of integrations.
  • Be patient and persistent. It might take some time to get a review or get the final approval from Committers.
  • Please follow ASF Code of Conduct for all communication including (but not limited to) comments on Pull Requests, Mailing list and Slack.
  • Be sure to read the Airflow Coding style.
  • Always keep your Pull Requests rebased, otherwise your build might fail due to changes not related to your commits.
    Apache Airflow is a community-driven project and together we are making it better 🚀.
    In case of doubts contact the developers at:
    Mailing List: dev@airflow.apache.org
    Slack: https://s.apache.org/airflow-slack

@boring-cyborg boring-cyborg bot added area:providers provider:google Google (including GCP) related issues labels Dec 28, 2025
@KamranImaaz KamranImaaz requested a review from potiuk December 28, 2025 17:40
@KamranImaaz KamranImaaz requested a review from potiuk December 29, 2025 11:44
@KamranImaaz
Copy link
Contributor Author

Hey @potiuk I have modified accordingly pls check it.

Copy link
Member

@potiuk potiuk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM - but @VladaZakharova and @MaksYermak approval would be great :)

@KamranImaaz
Copy link
Contributor Author

Thanks @potiuk for approving the changes.
@VladaZakharova @MaksYermak, would appreciate your review when convenient.

@KamranImaaz
Copy link
Contributor Author

@MaksYermak Modified the changes!

@KamranImaaz KamranImaaz requested a review from MaksYermak January 2, 2026 10:44
Copy link
Contributor

@MaksYermak MaksYermak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@KamranImaaz
Copy link
Contributor Author

LGTM

Thanks @MaksYermak :)

@potiuk potiuk merged commit 0a27deb into apache:main Jan 5, 2026
87 checks passed
@boring-cyborg
Copy link

boring-cyborg bot commented Jan 5, 2026

Awesome work, congrats on your first merged pull request! You are invited to check our Issue Tracker for additional contributions.

chirodip98 pushed a commit to chirodip98/airflow-contrib that referenced this pull request Jan 9, 2026
…tDataOperator (apache#59866)

* added warning message for deprecated project_id field in BigQueryGetDataOperator

* updated the deprecated code with standard format

* updated google provider bigquery document regarding deprecation

* created a seperate method to assign table_project_id using a deprecated method

* Fix formatting issues found by prek hooks

* modified the logs

---------

Co-authored-by: kamran imaz <136354689+Kamran-imaz@users.noreply.github.com>
stegololz pushed a commit to stegololz/airflow that referenced this pull request Jan 9, 2026
…tDataOperator (apache#59866)

* added warning message for deprecated project_id field in BigQueryGetDataOperator

* updated the deprecated code with standard format

* updated google provider bigquery document regarding deprecation

* created a seperate method to assign table_project_id using a deprecated method

* Fix formatting issues found by prek hooks

* modified the logs

---------

Co-authored-by: kamran imaz <136354689+Kamran-imaz@users.noreply.github.com>
@KamranImaaz KamranImaaz deleted the add-project_id-deprecation-warning branch January 12, 2026 15:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area:providers provider:google Google (including GCP) related issues

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants