-
Notifications
You must be signed in to change notification settings - Fork 16.3k
Add AirflowDeprecationWarning for deprecated project_id in BigQueryGetDataOperator #59866
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add AirflowDeprecationWarning for deprecated project_id in BigQueryGetDataOperator #59866
Conversation
|
Congratulations on your first Pull Request and welcome to the Apache Airflow community! If you have any issues or are unsure about any anything please check our Contributors' Guide (https://github.com/apache/airflow/blob/main/contributing-docs/README.rst)
|
providers/google/src/airflow/providers/google/cloud/operators/bigquery.py
Outdated
Show resolved
Hide resolved
providers/google/src/airflow/providers/google/cloud/operators/bigquery.py
Outdated
Show resolved
Hide resolved
|
Hey @potiuk I have modified accordingly pls check it. |
potiuk
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM - but @VladaZakharova and @MaksYermak approval would be great :)
…ject_id-deprecation-warning
|
Thanks @potiuk for approving the changes. |
providers/google/src/airflow/providers/google/cloud/operators/bigquery.py
Outdated
Show resolved
Hide resolved
|
@MaksYermak Modified the changes! |
MaksYermak
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Thanks @MaksYermak :) |
|
Awesome work, congrats on your first merged pull request! You are invited to check our Issue Tracker for additional contributions. |
…tDataOperator (apache#59866) * added warning message for deprecated project_id field in BigQueryGetDataOperator * updated the deprecated code with standard format * updated google provider bigquery document regarding deprecation * created a seperate method to assign table_project_id using a deprecated method * Fix formatting issues found by prek hooks * modified the logs --------- Co-authored-by: kamran imaz <136354689+Kamran-imaz@users.noreply.github.com>
…tDataOperator (apache#59866) * added warning message for deprecated project_id field in BigQueryGetDataOperator * updated the deprecated code with standard format * updated google provider bigquery document regarding deprecation * created a seperate method to assign table_project_id using a deprecated method * Fix formatting issues found by prek hooks * modified the logs --------- Co-authored-by: kamran imaz <136354689+Kamran-imaz@users.noreply.github.com>
Description:
Updated the Depricated field(Project_id) in alignment and format of Google Provider.
Updated the log/info message: Ignoring deprecated 'project_id' parameter because 'table_project_id' is provided.
Verified that all relevant unit tests for BigQueryGetDataOperator pass.
Impact:
Provides clear deprecation warnings for users following the new table_project_id parameter.
Maintains backward compatibility while encouraging migration to the updated parameter.
Testing:
Ran pytest for BigQueryGetDataOperator tests.
All synchronous tests passed; async tests skipped (fixture not available locally).