Cleanup of variables in settings.py #59875
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
boring-cyborg
bot
added
area:API
potiuk
reviewed
Dec 28, 2025
Member
|
Love it - that might really help with getting rid of the circular dependencies we have :) |
jscheffl
force-pushed
the
bugfix/variable-cleanup-in-settings-py
branch
from
b869fec to
f548ecb
Compare
jscheffl
added
the
full tests needed
jscheffl
requested review from
XD-DENG,
amoghrajesh,
ashb,
bugraoz93,
ephraimbuddy,
hussein-awala,
jason810496,
jedcunningham,
pierrejeambrun,
rawwar and
shubhamraj-git
as code owners
jscheffl
added
the
all versions
Contributor
Author
|
Force restart CI |
potiuk
approved these changes
Dec 29, 2025
potiuk
force-pushed
the
bugfix/variable-cleanup-in-settings-py
branch
from
f548ecb to
7ba0abe
Compare
54 tasks
Subham-KRLX
pushed a commit
to Subham-KRLX/airflow
that referenced
this pull request
Jan 2, 2026
* Cleanup of variables in settings.py * Fix pytest mocks
stegololz
pushed a commit
to stegololz/airflow
that referenced
this pull request
Jan 9, 2026
* Cleanup of variables in settings.py * Fix pytest mocks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As I was starting to clean further global variables in settings.py I noticed a couple of constants being defined here which are only used at one place in the codebase. In order to un-clutter the settings.py this PR proposes to remove some fields which in my view are just "lurking" around in the wrong place.