-
Notifications
You must be signed in to change notification settings - Fork 16.4k
Add E2E tests for DAG Runs page #59919
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
- Add DagRunsPage page object with locators and actions - Add test specs for DAG runs list, filtering, and navigation - Cover DAG run state changes
|
Congratulations on your first Pull Request and welcome to the Apache Airflow community! If you have any issues or are unsure about any anything please check our Contributors' Guide (https://github.com/apache/airflow/blob/main/contributing-docs/README.rst)
|
|
The WebKit E2E tests are failing in CI while Chromium and Firefox pass. Error: This appears to be a WebKit-specific CI environment issue (network/timing), not a test logic problem. Should I:
Thanks! |
|
@lin121291 Thanks for this PR! A few things:
Let me know if you have questions! |
|
@lin121291 can you resolve the comments, and we can merge post it |
… verification - Set 60s timeout for WebKit compatibility - Add beforeAll hook to create test data via API (failed/success states, multiple DAG IDs) - Replace waitForTimeout with proper element waits - Verify state and DAG ID filters return correct results - Add pagination test with offset/limit parameters - Remove redundant visual badge test
|
@vatsrahul1001 All feedback addressed in the latest commit. Thanks for the detailed review! |
|
Awesome work, congrats on your first merged pull request! You are invited to check our Issue Tracker for additional contributions. |
… PR pattern - Remove LoginPage import and all login-related code - Tests now receive authenticated page from Playwright's global storageState - Initialize DagsPage directly in each test function - Matches pattern from successfully merged PRs: apache#59943, apache#59919, apache#59734 - Fixes CI failures across Chromium, Firefox, and WebKit Addresses reviewer feedback from @vatsrahul1001
Add E2E tests for DAG Runs page Co-authored-by: Rahul Vats <43964496+vatsrahul1001@users.noreply.github.com> Co-authored-by: vatsrahul1001 <rah.sharma11@gmail.com>
What change does this PR introduce?
Adds end-to-end (E2E) tests for the DAG runs page (
/dag_runs) to improve test coverage of the UI.What does this PR do?
New Files:
airflow-core/src/airflow/ui/tests/e2e/pages/DagRunsPage.ts- Page Object Model for DAG runs pageairflow-core/src/airflow/ui/tests/e2e/specs/dag-runs.spec.ts- Test specificationsTest Coverage (as per DAGRUNS-001):
Related Issues
Closes #59309