Made sqlalchemy dependency optional for amazon provider #59941
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
boring-cyborg
bot
added
area:providers
provider:amazon
potiuk
approved these changes
Dec 31, 2025
Dev-iL
reviewed
Jan 4, 2026
| try: | ||
| from sqlalchemy.engine.url import URL | ||
| except ImportError: | ||
| URL = None |
Collaborator
There was a problem hiding this comment.
@potiuk Please note before approving similar PRs that leaving URL untyped (i.e. URL: Any before the try block) or unignored (# type: ignore[assignment,misc]) leads to mypy violations on SQLA2:
providers/amazon/src/airflow/providers/amazon/aws/hooks/redshift_sql.py:30: error: Cannot assign to a type [misc]
URL = create_engine = None
^~~
providers/amazon/src/airflow/providers/amazon/aws/hooks/redshift_sql.py:30: error: Incompatible types in assignment (expression has
type "None", variable has type "type[URL]") [assignment]
URL = create_engine = None
^
providers/amazon/src/airflow/providers/amazon/aws/hooks/redshift_sql.py:30: error: Incompatible types in assignment (expression has
type "None", variable has type overloaded function) [assignment]
URL = create_engine = None
^~~~
providers/amazon/src/airflow/providers/amazon/aws/hooks/athena_sql.py:28: error: Cannot assign to a type [misc]
URL = None
^~~
providers/amazon/src/airflow/providers/amazon/aws/hooks/athena_sql.py:28: error: Incompatible types in assignment (expression has type
"None", variable has type "type[URL]") [assignment]
URL = None
^~~~
chirodip98
pushed a commit
to chirodip98/airflow-contrib
that referenced
this pull request
Jan 5, 2026
* Made sqlalchemy dependency optional for amazon provider * Prek formatting
chirodip98
pushed a commit
to chirodip98/airflow-contrib
that referenced
this pull request
Jan 8, 2026
* Made sqlalchemy dependency optional for amazon provider * Prek formatting
chirodip98
pushed a commit
to chirodip98/airflow-contrib
that referenced
this pull request
Jan 9, 2026
* Made sqlalchemy dependency optional for amazon provider * Prek formatting
stegololz
pushed a commit
to stegololz/airflow
that referenced
this pull request
Jan 9, 2026
* Made sqlalchemy dependency optional for amazon provider * Prek formatting
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes: #59896
Made SQLAlchemy an optional dependency for the Amazon provider. The imports are now wrapped with try/except and
AirflowOptionalProviderFeatureException()gets raised if it is not installed.^ Add meaningful description above
Read the Pull Request Guidelines for more information.
In case of fundamental code changes, an Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in a newsfragment file, named
{pr_number}.significant.rstor{issue_number}.significant.rst, in airflow-core/newsfragments.