Fix log task instance join #59973
Merged
Fix log task instance join #59973
+89
−4
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Prab-27
reviewed
Dec 31, 2025
Contributor
|
Thanks for the pr! |
2 tasks
Subham-KRLX
force-pushed
the
fix-log-task-instance-join
branch
from
0addbc3 to
d7e59f0
Compare
henry3260
reviewed
Jan 2, 2026
Subham-KRLX
force-pushed
the
fix-log-task-instance-join
branch
2 times, most recently
from
073c9d1 to
fb529c7
Compare
Subham-KRLX
requested review from
Lee-W,
amoghrajesh,
bugraoz93,
dstandish,
ephraimbuddy,
gopidesupavan,
guan404ming,
hussein-awala,
jason810496,
jedcunningham,
josh-fell,
jscheffl,
kaxil,
mobuchowski,
o-nikolas,
potiuk,
uranusjr and
vincbeck
as code owners
jscheffl
reviewed
Jan 4, 2026
Lee-W
reviewed
Jan 5, 2026
Contributor
Author
|
I think now its good to go. |
jason810496
reviewed
Jan 5, 2026
Member
jason810496
left a comment
jason810496
left a comment
There was a problem hiding this comment.
I think now its good to go.
We still encounter the same ruff formatting static check failure: https://github.com/apache/airflow/actions/runs/20718428075/job/59476214319?pr=59973
Contributor
Author
|
Fixed the ruff formatting issue by flattening the primaryjoin definition. Validated locally with ruff==0.14.10 and checks are passing now. |
jscheffl
reviewed
Jan 5, 2026
jscheffl
reviewed
Jan 5, 2026
jason810496
reviewed
Jan 7, 2026
Member
jason810496
left a comment
jason810496
left a comment
There was a problem hiding this comment.
Thanks for the update, LGTM.
jason810496
added
the
backport-to-v3-1-test
Lee-W
approved these changes
Jan 7, 2026
potiuk
approved these changes
Jan 7, 2026
2 tasks
github-actions bot
pushed a commit
that referenced
this pull request
Jan 7, 2026
* Fix incorrect Log and TaskInstance join query * Fix log task instance join foreign keys and remove stray newsfragment * Remove unused task variable assignments in test_log_task_instance_join_correctness * Fix CI failures and address reviewer comments: revert unrelated doc changes, clean up tests, add Mapped type hints to Log relationships, and run ruff formatting * Restore newsfragment and fix missing import in log.py * Fix reviewer feedback: add license, move imports, and fix newsfragments * Fix ruff static check failure in log.py * Flatten primaryjoin definition to fix formatting * Fix newsfragments per review: restore 58337 and remove 59965 * Remove unused import in log.py --------- (cherry picked from commit 91af86e) Co-authored-by: Subham <subhamsangwan26@gmail.com> Co-authored-by: Jason(Zhe-You) Liu <68415893+jason810496@users.noreply.github.com>
Backport successfully created: v3-1-test
|
jscheffl
pushed a commit
that referenced
this pull request
Jan 7, 2026
* [v3-1-test] Fix log task instance join (#59973) * Fix incorrect Log and TaskInstance join query * Fix log task instance join foreign keys and remove stray newsfragment * Remove unused task variable assignments in test_log_task_instance_join_correctness * Fix CI failures and address reviewer comments: revert unrelated doc changes, clean up tests, add Mapped type hints to Log relationships, and run ruff formatting * Restore newsfragment and fix missing import in log.py * Fix reviewer feedback: add license, move imports, and fix newsfragments * Fix ruff static check failure in log.py * Flatten primaryjoin definition to fix formatting * Fix newsfragments per review: restore 58337 and remove 59965 * Remove unused import in log.py --------- (cherry picked from commit 91af86e) Co-authored-by: Subham <subhamsangwan26@gmail.com> Co-authored-by: Jason(Zhe-You) Liu <68415893+jason810496@users.noreply.github.com> * Fix backport: Remove Mapped type hints for SQLAlchemy 1.x compatibility * Fix unused import in log.py * Update airflow-core/src/airflow/models/log.py --------- Co-authored-by: Jason(Zhe-You) Liu <68415893+jason810496@users.noreply.github.com> Co-authored-by: Jarek Potiuk <jarek@potiuk.com>
61 tasks
chirodip98
pushed a commit
to chirodip98/airflow-contrib
that referenced
this pull request
Jan 9, 2026
* Fix incorrect Log and TaskInstance join query * Fix log task instance join foreign keys and remove stray newsfragment * Remove unused task variable assignments in test_log_task_instance_join_correctness * Fix CI failures and address reviewer comments: revert unrelated doc changes, clean up tests, add Mapped type hints to Log relationships, and run ruff formatting * Restore newsfragment and fix missing import in log.py * Fix reviewer feedback: add license, move imports, and fix newsfragments * Fix ruff static check failure in log.py * Flatten primaryjoin definition to fix formatting * Fix newsfragments per review: restore 58337 and remove 59965 * Remove unused import in log.py --------- Co-authored-by: Jason(Zhe-You) Liu <68415893+jason810496@users.noreply.github.com>
stegololz
pushed a commit
to stegololz/airflow
that referenced
this pull request
Jan 9, 2026
* Fix incorrect Log and TaskInstance join query * Fix log task instance join foreign keys and remove stray newsfragment * Remove unused task variable assignments in test_log_task_instance_join_correctness * Fix CI failures and address reviewer comments: revert unrelated doc changes, clean up tests, add Mapped type hints to Log relationships, and run ruff formatting * Restore newsfragment and fix missing import in log.py * Fix reviewer feedback: add license, move imports, and fix newsfragments * Fix ruff static check failure in log.py * Flatten primaryjoin definition to fix formatting * Fix newsfragments per review: restore 58337 and remove 59965 * Remove unused import in log.py --------- Co-authored-by: Jason(Zhe-You) Liu <68415893+jason810496@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
7 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix the incorrect Log and TaskInstance join query
This PR addresses the issue: #59965.
The Log.task_instance relationship in
airflow/models/log.pyhas been updated to use a strict join on the following fields:This change ensures that log entries are correctly associated with their corresponding task instances, resolving an issue where the relationship was previously defined with a primaryjoin that only checked for matching
task_id.