Skip to content

Conversation

@ftakelait
Copy link
Contributor

@ftakelait ftakelait commented Jan 1, 2026

Summary

Adds missing connection type attributes (conn_type, conn_name_attr,
default_conn_name, hook_name) to WinRMHook to enable proper
connection type registration in the Airflow UI.

Related Issue

Fixes part of #28790

Testing

  • Unit tests pass (7/7)
  • Verified attributes load correctly via Python import

Add conn_type, conn_name_attr, default_conn_name, and hook_name
to WinRMHook to enable proper connection type registration in UI.

Fixes apache#28790

Signed-off-by: Fouzi Takelait <ftakelait@gmail.com>
@boring-cyborg
Copy link

boring-cyborg bot commented Jan 1, 2026

Congratulations on your first Pull Request and welcome to the Apache Airflow community! If you have any issues or are unsure about any anything please check our Contributors' Guide (https://github.com/apache/airflow/blob/main/contributing-docs/README.rst)
Here are some useful points:

  • Pay attention to the quality of your code (ruff, mypy and type annotations). Our prek-hooks will help you with that.
  • In case of a new feature add useful documentation (in docstrings or in docs/ directory). Adding a new operator? Check this short guide Consider adding an example DAG that shows how users should use it.
  • Consider using Breeze environment for testing locally, it's a heavy docker but it ships with a working Airflow and a lot of integrations.
  • Be patient and persistent. It might take some time to get a review or get the final approval from Committers.
  • Please follow ASF Code of Conduct for all communication including (but not limited to) comments on Pull Requests, Mailing list and Slack.
  • Be sure to read the Airflow Coding style.
  • Always keep your Pull Requests rebased, otherwise your build might fail due to changes not related to your commits.
    Apache Airflow is a community-driven project and together we are making it better 🚀.
    In case of doubts contact the developers at:
    Mailing List: dev@airflow.apache.org
    Slack: https://s.apache.org/airflow-slack

@jscheffl jscheffl merged commit 8028744 into apache:main Jan 1, 2026
85 checks passed
@boring-cyborg
Copy link

boring-cyborg bot commented Jan 1, 2026

Awesome work, congrats on your first merged pull request! You are invited to check our Issue Tracker for additional contributions.

stegololz pushed a commit to stegololz/airflow that referenced this pull request Jan 9, 2026
Add conn_type, conn_name_attr, default_conn_name, and hook_name
to WinRMHook to enable proper connection type registration in UI.

Fixes apache#28790

Signed-off-by: Fouzi Takelait <ftakelait@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants