Skip to content

Conversation

@amoghrajesh
Copy link
Contributor

Tests on main are broken similar to:

________________________________________________________________ test_dag_state_change_process_pool_size_invalid_value_raise_error[false] ________________________________________________________________
task-sdk/src/airflow/sdk/_shared/configuration/parser.py:1050: in getint
    return int(val)
E   ValueError: invalid literal for int() with base 10: 'false'

During handling of the above exception, another exception occurred:
providers/openlineage/tests/unit/openlineage/test_conf.py:554: in test_dag_state_change_process_pool_size_invalid_value_raise_error
    dag_state_change_process_pool_size()
providers/openlineage/src/airflow/providers/openlineage/conf.py:155: in dag_state_change_process_pool_size
    return conf.getint(_CONFIG_SECTION, "dag_state_change_process_pool_size", fallback="1")
task-sdk/src/airflow/sdk/_shared/configuration/parser.py:1052: in getint
    raise AirflowConfigException(
E   airflow.sdk._shared.configuration.exceptions.AirflowConfigException: Failed to convert value to int. Please check "dag_state_change_process_pool_size" key in "openlineage" section. Current value: "false".

This is because of #60026. This PR moved conf to compat sdk but not AirflowConfigException, so there was a mismatch in the exception raised and captured. Expected: airflow.exceptions.AirflowConfigException, caught: airflow.sdk._shared.configuration.exceptions.AirflowConfigException.

Hence, moving this exception into compat sdk as well. It would be beneficial in long run to do this.


^ Add meaningful description above
Read the Pull Request Guidelines for more information.
In case of fundamental code changes, an Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in a newsfragment file, named {pr_number}.significant.rst or {issue_number}.significant.rst, in airflow-core/newsfragments.

@amoghrajesh
Copy link
Contributor Author

Lets see how this one goes

@amoghrajesh amoghrajesh added the full tests needed We need to run full set of tests for this PR to merge label Jan 2, 2026
@amoghrajesh amoghrajesh closed this Jan 2, 2026
@amoghrajesh amoghrajesh reopened this Jan 2, 2026
@amoghrajesh amoghrajesh added this to the Airflow 3.2.0 milestone Jan 2, 2026
@amoghrajesh amoghrajesh merged commit a09ed06 into apache:main Jan 2, 2026
188 of 220 checks passed
@potiuk
Copy link
Member

potiuk commented Jan 2, 2026

Nice

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants