[v3-1-test] Fix ApprovalOperator with SimpleAuthManager when all_admi… #60116
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ns=True (apache#59399) (cherry picked from commit d95d8ba) Co-authored-by: Victor Kwong <109138344+TempestShaw@users.noreply.github.com> Co-authored-by: Vincent <97131062+vincbeck@users.noreply.github.com>
Lee-W
requested review from
bugraoz93,
ephraimbuddy,
jason810496,
pierrejeambrun,
rawwar,
shubhamraj-git and
vincbeck
as code owners
Member
Author
|
I think this is a valid "fix", but would like to have @ephraimbuddy confirm whether we want to make it part of 3.1.6 or 3.2.0 |
Contributor
Since it's a bug fix, we are good with it being in 3.1.6 |
Member
Author
|
Then I'll go ahead and merge it |
61 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…ns=True (#59399)
(cherry picked from commit d95d8ba)
^ Add meaningful description above
Read the Pull Request Guidelines for more information.
In case of fundamental code changes, an Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in a newsfragment file, named
{pr_number}.significant.rstor{issue_number}.significant.rst, in airflow-core/newsfragments.