Add integration tests for /events Audit log page #60122

Prajwal7842 · 2026-01-05T14:29:17Z

This PR adds playwright integration tests for /events Audit log page for Airflow UI.

Covers following things from listed down in the issues:

Audit Logs Display

Navigate to the Audit Logs page (/events)
Verify the logs table is displayed
Verify log entries show: timestamp, event type, DAG ID, user, etc.
Verify pagination works
Verify column sorting works

Search/Filter Logs

Verify search input is visible

closes: #59931
releated: #59028

The integration tests were locally run 5+ times consecutively and all runs passed successfully to avoid any flakiness
Sample run:

Prajwal7842 · 2026-01-06T11:57:22Z

@vatsrahul1001 can you take a look. Builds are passing now. Thanks

vatsrahul1001 · 2026-01-06T12:14:25Z

Thanks, I will review it soon!

vatsrahul1001 · 2026-01-06T14:14:10Z

@Prajwal7842 Thanks for the PR! A few things to address:

Test naming - Remove "should" prefix (use "verify ..." instead of "should verify ...")
Remove hardcoded waits - waitForTimeout(5000) is slow and fragile. Use proper Playwright assertions:
await expect(async () => {
const indicator = await eventsPage.getColumnSortIndicator(0);
expect(indicator).not.toBe("none");
}).toPass({ timeout: 10_000 });
Move DAG trigger to beforeAll - Current "Events with Generated Data" tests depend on first test running. Move triggerDag to beforeAll for proper isolation
Column selectors are fragile - Using .nth(1), .nth(2) breaks if column order changes. Use text/role-based selectors:
this.eventTypeColumn = page.getByRole("columnheader", { name: /event/i });
5. Sorting test weak - Only checks indicator, not actual sort order. Capture data before/after and verify it changed
Filter test incomplete - Only opens menu, doesn't apply filter. Add test that applies filter and verifies results
Fix pagination URL - Missing / prefix and limit=1 is too small:
return "/events?limit=5&offset=0";
8. Remove waitForTimeout method

Let me know if you have questions!

vatsrahul1001 · 2026-01-06T14:15:53Z

airflow-core/src/airflow/ui/tests/e2e/specs/events-page.spec.ts

+    await eventsPage.navigate();
+    await eventsPage.waitForEventsTable();
+
+    await eventsPage.waitForTimeout(5000);


This adds 10 seconds of unnecessary wait time

await expect(async () => { const sortIndicator = await eventsPage.getColumnSortIndicator(0); expect(sortIndicator).not.toBe("none"); }).toPass({ timeout: 10_000 });

vatsrahul1001 · 2026-01-06T14:16:58Z

airflow-core/src/airflow/ui/tests/e2e/specs/events-page.spec.ts

+    test.setTimeout(3 * 60 * 1000); // 3 minutes timeout
+
+    // First, trigger a DAG to generate audit log entries
+    await dagsPage.triggerDag(testDagId);


Move trigger dag to beforeAll

test.describe("Events with Generated Data", () => { const testDagId = testConfig.testDag.id; test.beforeAll(async ({ browser }) => { test.setTimeout(3 * 60 * 1000); const context = await browser.newContext({ storageState: AUTH_FILE }); const page = await context.newPage(); const dagsPage = new DagsPage(page); await dagsPage.triggerDag(testDagId); await context.close(); }); test.beforeEach(({ page }) => { eventsPage = new EventsPage(page); });

vatsrahul1001 · 2026-01-06T14:20:18Z

airflow-core/src/airflow/ui/tests/e2e/pages/EventsPage.ts

+    this.eventsTable = page.getByRole("table");
+    this.filterBar = page.locator('div:has(button:has-text("Filter"))').first();
+    // Use table header selectors - will check for presence of key columns
+    this.timestampColumn = page.locator("thead th").first();


If column order changes, all tests break.
Maybe we can use something like below

this.timestampColumn = page.getByRole("columnheader", { name: /when/i }); this.eventTypeColumn = page.getByRole("columnheader", { name: /event/i }); this.userColumn = page.getByRole("columnheader", { name: /user/i });

vatsrahul1001 · 2026-01-06T14:20:57Z

airflow-core/src/airflow/ui/tests/e2e/specs/events-page.spec.ts

+    await expect(eventsPage.eventsTable).toBeVisible({ timeout: 10_000 });
+  });
+
+  test("should verify column sorting works", async () => {


This doesn't verify the data is actually sorted.
Capture data before/after and verify order

vatsrahul1001 · 2026-01-06T14:49:39Z

airflow-core/src/airflow/ui/tests/e2e/specs/events-page.spec.ts

+    eventsPage = new EventsPage(page);
+  });
+
+  test("should verify search input is visible", async () => {


Test only checks that the filter UI exists:

Opens filter menu

Verifies menu items visible

Closes menu

This is NOT a filter test - it's just checking the filter UI is present.

Prajwal7842 · 2026-01-08T13:53:27Z

@Prajwal7842 Thanks for the PR! A few things to address:

Test naming - Remove "should" prefix (use "verify ..." instead of "should verify ...")

Remove hardcoded waits - waitForTimeout(5000) is slow and fragile. Use proper Playwright assertions:
await expect(async () => {
const indicator = await eventsPage.getColumnSortIndicator(0);
expect(indicator).not.toBe("none");
}).toPass({ timeout: 10_000 });

Move DAG trigger to beforeAll - Current "Events with Generated Data" tests depend on first test running. Move triggerDag to beforeAll for proper isolation

Column selectors are fragile - Using .nth(1), .nth(2) breaks if column order changes. Use text/role-based selectors:
this.eventTypeColumn = page.getByRole("columnheader", { name: /event/i });
5. Sorting test weak - Only checks indicator, not actual sort order. Capture data before/after and verify it changed

Filter test incomplete - Only opens menu, doesn't apply filter. Add test that applies filter and verifies results

Fix pagination URL - Missing / prefix and limit=1 is too small:
return "/events?limit=5&offset=0";
8. Remove waitForTimeout method

Let me know if you have questions!

Thanks @vatsrahul1001 for the review. I have addressed the comments.
For point (5), regarding integration tests for filter, I am working on it in the follow up diff. Thanks.

vatsrahul1001 · 2026-01-13T17:08:28Z

@Prajwal7842 #59734 is already merged now. Can you rebase. I think you can reuse alot of code

vatsrahul1001 · 2026-01-18T19:12:52Z

@Prajwal7842 How are we progressing on this?

Prajwal7842 · 2026-01-19T14:20:57Z

@Prajwal7842 How are we progressing on this?

#59931 (comment)

Prajwal7842 · 2026-01-20T14:25:19Z

@vatsrahul1001 updated the tests as per suggestions. PTAL. Thanks

vatsrahul1001 · 2026-01-23T11:08:27Z

Thanks @Prajwal7842 I will review soon

vatsrahul1001 · 2026-01-26T11:54:40Z

airflow-core/src/airflow/ui/tests/e2e/pages/EventsPage.ts

+    const menuItem = filterMenu.locator(`[role="menuitem"]:has-text("${filterName}")`);
+
+    await menuItem.click();
+    await this.page.waitForTimeout(300);


Could use explicit wait

vatsrahul1001 · 2026-01-26T11:55:11Z

airflow-core/src/airflow/ui/tests/e2e/pages/EventsPage.ts

@@ -21,8 +21,10 @@ import { BasePage } from "tests/e2e/pages/BasePage";

 export class EventsPage extends BasePage {
  public readonly eventColumn: Locator;


These are defined but not directly used:
eventColumn, extraColumn, ownerColumn, whenColumn
clickColumnHeader() (only clickColumnToSort() is used)

Consider removing if not needed.

Hi, these columns are being used in dag-audit-log.spec.ts and its usage is added into the previous diff, hence will be keeping this.

vatsrahul1001 · 2026-01-26T11:56:12Z

airflow-core/src/airflow/ui/tests/e2e/pages/EventsPage.ts

+    const eventText = await eventCell.textContent();
+    const userText = await userCell.textContent();
+
+    if (


We can use this
expect(whenText?.trim()).toBeTruthy();

vatsrahul1001 · 2026-01-28T04:45:02Z

@Prajwal7842 I see tests are failing. can you check?

Prajwal7842 requested a review from vatsrahul1001 as a code owner January 5, 2026 14:29

boring-cyborg bot added the area:UI Related to UI/UX. For Frontend Developers. label Jan 5, 2026

Prajwal7842 changed the title ~~Add integration tests for /events Audit log page~~ Add integration tests for /events Audit log page (Part 1) Jan 5, 2026

Prajwal7842 force-pushed the prajwal7842/issue_59931 branch from 71c92e3 to 8b842f2 Compare January 6, 2026 09:57

vatsrahul1001 reviewed Jan 6, 2026

View reviewed changes

Prajwal7842 requested a review from choo121600 as a code owner January 8, 2026 13:49

Prajwal7842 force-pushed the prajwal7842/issue_59931 branch from 28790a3 to b76c454 Compare January 8, 2026 14:04

Prajwal7842 requested a review from vatsrahul1001 January 9, 2026 04:14

Prajwal7842 force-pushed the prajwal7842/issue_59931 branch from b76c454 to eab74e8 Compare January 20, 2026 14:19

Prajwal7842 changed the title ~~Add integration tests for /events Audit log page (Part 1)~~ Add integration tests for /events Audit log page Jan 20, 2026

vatsrahul1001 reviewed Jan 26, 2026

View reviewed changes

Prajwal7842 force-pushed the prajwal7842/issue_59931 branch 2 times, most recently from 8d66c9a to a01107f Compare January 27, 2026 13:18

Prajwal7842 added 7 commits January 28, 2026 11:04

Add integration tests for /events Audit log page

a375846

Update tests

505c191

Update tests

71b0f5f

Update tests

02f8e23

Address comments

cbea694

Update tests

2adbdbc

Update sorting test

343ad0a

Prajwal7842 force-pushed the prajwal7842/issue_59931 branch from a01107f to 343ad0a Compare January 28, 2026 06:01

		@@ -21,8 +21,10 @@ import { BasePage } from "tests/e2e/pages/BasePage";

		export class EventsPage extends BasePage {
		public readonly eventColumn: Locator;

Add integration tests for /events Audit log page #60122

Are you sure you want to change the base?

Add integration tests for /events Audit log page #60122

Uh oh!

Conversation

Prajwal7842 commented Jan 5, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Prajwal7842 commented Jan 6, 2026

Uh oh!

vatsrahul1001 commented Jan 6, 2026

Uh oh!

vatsrahul1001 commented Jan 6, 2026

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Prajwal7842 commented Jan 8, 2026

Uh oh!

vatsrahul1001 commented Jan 13, 2026

Uh oh!

vatsrahul1001 commented Jan 18, 2026

Uh oh!

Prajwal7842 commented Jan 19, 2026

Uh oh!

Prajwal7842 commented Jan 20, 2026

Uh oh!

vatsrahul1001 commented Jan 23, 2026

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

vatsrahul1001 commented Jan 28, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

Prajwal7842 commented Jan 5, 2026 •

edited

Loading