-
Notifications
You must be signed in to change notification settings - Fork 16.3k
Add meaningful DAG-level documentation to example DAGs #60149
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
kalel-commits
wants to merge
6
commits into
apache:main
Choose a base branch
from
kalel-commits:add-doc-md-to-example-dags
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+159
−26
Open
Changes from all commits
Commits
Show all changes
6 commits
Select commit
Hold shift + click to select a range
06d7f88
Add doc_md documentation to python decorator example DAG
kalel-commits b2fed57
Add meaningful DAG-level documentation to example DAGs
kalel-commits d4f67b9
Improve TaskFlow example DAG documentation and fix formatting
kalel-commits 4ce430b
Fix doc_md formatting issues flagged by static checks
kalel-commits a5fb0f7
Fix trailing whitespace causing static check failure
kalel-commits ba8efec
Apply prek auto-fixes for static checks
kalel-commits File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
One idea how we make docs in Dags consistent at work: How about adding all the documentation here as pydoc in the header of the file and must define it here as
doc_md=__doc__?There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the suggestion, that’s a nice idea and I agree it would help keep DAG documentation consistent and co-located with the code.
For this PR, I’ve intentionally kept the documentation inline via doc_md to align with the existing pattern used in current example and tutorial DAGs. I wanted to keep the scope limited to addressing the missing Docs tab content without introducing a broader structural change.
That said, I like the doc_md = doc approach and would be happy to explore this as a follow-up or incremental PR, especially if there’s interest in standardizing this pattern across example DAGs. Happy to take guidance on whether that would be preferred going forward.