-
Notifications
You must be signed in to change notification settings - Fork 16.3k
Fix signal handling in triggerer job runner #60190
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
We were not registering our signal handler in the triggerer job. This meant our logging, to improve visibility into the shutdown process, was missing.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Since this is running async loop we souls use that for signal handling, not the sync version
https://docs.python.org/3/library/asyncio-eventloop.html#unix-signals
uranusjr
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Makes sense, although I wonder if there’s a better way to manage these instead of have register calls in (seemingly) random places.
|
Using |
We were not registering our signal handler in the triggerer job. This meant our logging, to improve visibility into the shutdown process, was missing. (cherry picked from commit ee163cd) Co-authored-by: Jed Cunningham <66968678+jedcunningham@users.noreply.github.com>
) We were not registering our signal handler in the triggerer job. This meant our logging, to improve visibility into the shutdown process, was missing. (cherry picked from commit ee163cd) Co-authored-by: Jed Cunningham <66968678+jedcunningham@users.noreply.github.com>
We were not registering our signal handler in the triggerer job. This meant our logging, to improve visibility into the shutdown process, was missing.
We were not registering our signal handler in the triggerer job. This meant our logging, to improve visibility into the shutdown process, was missing.
We were not registering our signal handler in the triggerer job. This meant our logging, to improve visibility into the shutdown process, was missing.
Before:
After: