Added state validation to delete dag run endpoint #60195
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
justinpakzad
requested review from
bugraoz93,
ephraimbuddy,
jason810496,
pierrejeambrun,
rawwar and
shubhamraj-git
as code owners
jason810496
reviewed
Jan 7, 2026
Member
jason810496
left a comment
jason810496
left a comment
There was a problem hiding this comment.
Thanks for the PR! LGTM if CI pass.
jason810496
added
the
backport-to-v3-1-test
github-actions bot
pushed a commit
that referenced
this pull request
Jan 7, 2026
(cherry picked from commit 85842d4) Co-authored-by: Justin Pakzad <justinpak303@gmail.com>
Backport successfully created: v3-1-test
|
potiuk
pushed a commit
that referenced
this pull request
Jan 7, 2026
chirodip98
pushed a commit
to chirodip98/airflow-contrib
that referenced
this pull request
Jan 9, 2026
stegololz
pushed a commit
to stegololz/airflow
that referenced
this pull request
Jan 9, 2026
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR implements state validation for the dag run delete endpoint. If the state of the dag run is not in the DAGRunPatchStates (i.e. if it's running) we return a 409 error indicating that it can't be deleted in said state. I added an additional test which attempts to delete a dag run while it's in a running state and validates the expected response.
closes: #59497
^ Add meaningful description above
Read the Pull Request Guidelines for more information.
In case of fundamental code changes, an Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in a newsfragment file, named
{pr_number}.significant.rstor{issue_number}.significant.rst, in airflow-core/newsfragments.