Skip to content

Literal to str Enum for ResourceMethod & ExtendedResourceMethod #60244

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
uranusjr merged 3 commits into from
Jan 12, 2026
Merged

Literal to str Enum for ResourceMethod & ExtendedResourceMethod #60244

uranusjr merged 3 commits into from
Jan 12, 2026
+70 −18

Conversation

@steveahnahn
Copy link
Contributor

@steveahnahn steveahnahn commented Jan 7, 2026

Summary

Convert ResourceMethod and ExtendedResourceMethod from Literal type aliases to proper Enum classes.

This change:

  • Provides runtime validation for HTTP method values
  • Improves IDE autocomplete and discoverability
  • Maintains full backward compatibility (string comparisons still work)
  • Replaces get_args() pattern with cleaner enum iteration

vincbeck
vincbeck approved these changes Jan 7, 2026
View reviewed changes
Copy link
Contributor

@vincbeck vincbeck left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice!

@uranusjr
Copy link
Member

uranusjr commented Jan 8, 2026

Need to fix static checks and compat

@steveahnahn
Copy link
Contributor Author

steveahnahn commented Jan 9, 2026

Added backwards compatibility helpers for Literal→Enum migration

Provider compat tests run against Airflow 3.0.x/3.1.x which still use Literal types.
Helper functions detect type at runtime to support both old (Literal) and new (Enum)

Enum only can be used in future after iterative ver upgrades

@steveahnahn steveahnahn requested a review from bugraoz93 January 11, 2026 20:27
@uranusjr uranusjr merged commit f1b0fdf into apache:main Jan 12, 2026
128 checks passed
iharsh02 pushed a commit to iharsh02/airflow that referenced this pull request Jan 13, 2026
@steveahnahn @iharsh02
Literal to str Enum for ResourceMethod & ExtendedResourceMethod (apac…
8f22aa2 
…he#60244)
@jscheffl jscheffl mentioned this pull request Jan 14, 2026
Closed
jason810496 pushed a commit to jason810496/airflow that referenced this pull request Jan 22, 2026
@steveahnahn @jason810496
Literal to str Enum for ResourceMethod & ExtendedResourceMethod (apac…
fa47060 
…he#60244)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@uranusjr uranusjr uranusjr approved these changes

@vincbeck vincbeck vincbeck approved these changes

@bugraoz93 bugraoz93 Awaiting requested review from bugraoz93 bugraoz93 is a code owner

Assignees

No one assigned

Labels

area:API Airflow's REST/HTTP API area:providers provider:keycloak

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@steveahnahn @uranusjr @bugraoz93 @vincbeck