-
Notifications
You must be signed in to change notification settings - Fork 16.3k
Make SQLAlchemy optional for Postgres provider #60257
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
hi @vincbeck |
|
@vincbeck , |
|
Looks good on my side + CI is the passing. I'll wait others to approve as well just to be sure |
|
can you pls tag them |
|
You already did, you need to give them time. Open source works thanks to people willing to contribute on their free time. They'll review your PR at some point, do not worry |
|
Awesome work, congrats on your first merged pull request! You are invited to check our Issue Tracker for additional contributions. |
Co-authored-by: Your Name <youremail@example.com>
This PR makes SQLAlchemy an optional dependency for the Postgres provider,
following the same pattern used by other providers (e.g. Presto, Exasol).
Summary of changes:
This aligns the Postgres provider with the guidance described in the parent issue.