fix: Remove explicit bg color from active filter buttons#60364
Closed
choo121600 wants to merge 1 commit intoapache:mainfrom
Closed
fix: Remove explicit bg color from active filter buttons#60364choo121600 wants to merge 1 commit intoapache:mainfrom
choo121600 wants to merge 1 commit intoapache:mainfrom
Conversation
Member
Author
|
This change is already included in PR #60346, so I’ll close this one. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In light mode, the active button was rendered with colorPalette.muted, causing the button color to appear washed out.
Since the solid variant already provides sufficient visual distinction for the active state,
the additional muted background override has been removed.
I had only been looking at dark mode, but once I checked light mode, the issue became noticeable 😅
Before
After
Was generative AI tooling used to co-author this PR?
{pr_number}.significant.rstor{issue_number}.significant.rst, in airflow-core/newsfragments.