-
Notifications
You must be signed in to change notification settings - Fork 16.3k
Change starlette import to fastapi #60382
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
Congratulations on your first Pull Request and welcome to the Apache Airflow community! If you have any issues or are unsure about any anything please check our Contributors' Guide (https://github.com/apache/airflow/blob/main/contributing-docs/README.rst)
|
jason810496
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the PR! LGTM overall.
https://github.com/apache/airflow/actions/runs/20886590921/job/60010997219?pr=60382 Some static checks still need fix, thanks!
4adbff6 to
84652d4
Compare
|
Awesome work, congrats on your first merged pull request! You are invited to check our Issue Tracker for additional contributions. |
Description
This PR change
starletteimport tofastapi,fastapire-exportstarlettedependencies for convenience and consistency, we should use it if possible.However, the following starlette imports must remain because FastAPI does not re-export these modules:
BaseHTTPMiddlewareWhy: FastAPI intentionally does not re-export
BaseHTTPMiddleware. There is nofastapi.middleware.basemodule.References:
BaseHTTPMiddlewareto FastAPI was answered with: "Is there a particular reason you don't just import it directly from Starlette, since FastAPI depends on Starlette?" (marked as accepted answer)BaseHTTPMiddleware.Was generative AI tooling used to co-author this PR?
Generated-by: [Cursor, Claude] following the guidelines