Skip to content

Conversation

@unknowntpo
Copy link
Contributor

Description

This PR change starlette import to fastapi, fastapi re-export starlette dependencies for convenience and consistency, we should use it if possible.

However, the following starlette imports must remain because FastAPI does not re-export these modules:

BaseHTTPMiddleware

Why: FastAPI intentionally does not re-export BaseHTTPMiddleware. There is no fastapi.middleware.base module.

References:


Was generative AI tooling used to co-author this PR?

  • Yes (please specify the tool below)

Generated-by: [Cursor, Claude] following the guidelines


@boring-cyborg
Copy link

boring-cyborg bot commented Jan 11, 2026

Congratulations on your first Pull Request and welcome to the Apache Airflow community! If you have any issues or are unsure about any anything please check our Contributors' Guide (https://github.com/apache/airflow/blob/main/contributing-docs/README.rst)
Here are some useful points:

  • Pay attention to the quality of your code (ruff, mypy and type annotations). Our prek-hooks will help you with that.
  • In case of a new feature add useful documentation (in docstrings or in docs/ directory). Adding a new operator? Check this short guide Consider adding an example DAG that shows how users should use it.
  • Consider using Breeze environment for testing locally, it's a heavy docker but it ships with a working Airflow and a lot of integrations.
  • Be patient and persistent. It might take some time to get a review or get the final approval from Committers.
  • Please follow ASF Code of Conduct for all communication including (but not limited to) comments on Pull Requests, Mailing list and Slack.
  • Be sure to read the Airflow Coding style.
  • Always keep your Pull Requests rebased, otherwise your build might fail due to changes not related to your commits.
    Apache Airflow is a community-driven project and together we are making it better 🚀.
    In case of doubts contact the developers at:
    Mailing List: dev@airflow.apache.org
    Slack: https://s.apache.org/airflow-slack

Copy link
Member

@jason810496 jason810496 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR! LGTM overall.

https://github.com/apache/airflow/actions/runs/20886590921/job/60010997219?pr=60382 Some static checks still need fix, thanks!

@uranusjr uranusjr merged commit bccf180 into apache:main Jan 12, 2026
128 checks passed
@boring-cyborg
Copy link

boring-cyborg bot commented Jan 12, 2026

Awesome work, congrats on your first merged pull request! You are invited to check our Issue Tracker for additional contributions.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants