Improve insert content when generate docker file#60393
Merged
jscheffl merged 1 commit intoapache:mainfrom Jan 11, 2026
Merged
Conversation
tuanhm2911
requested review from
amoghrajesh,
ashb,
bugraoz93,
gopidesupavan,
jason810496,
jscheffl,
kaxil and
potiuk
as code owners
boring-cyborg
bot
added
area:dev-tools
backport-to-v3-1-test
|
Congratulations on your first Pull Request and welcome to the Apache Airflow community! If you have any issues or are unsure about any anything please check our Contributors' Guide (https://github.com/apache/airflow/blob/main/contributing-docs/README.rst)
|
|
Awesome work, congrats on your first merged pull request! You are invited to check our Issue Tracker for additional contributions. |
github-actions bot
pushed a commit
that referenced
this pull request
Jan 11, 2026
(cherry picked from commit fd90666) Co-authored-by: Tuan Hoang Minh <9130269+tuanhm2911@users.noreply.github.com>
Backport successfully created: v3-1-test
|
jscheffl
pushed a commit
that referenced
this pull request
Jan 11, 2026
ephraimbuddy
pushed a commit
that referenced
this pull request
Jan 13, 2026
iharsh02
pushed a commit
to iharsh02/airflow
that referenced
this pull request
Jan 13, 2026
ephraimbuddy
pushed a commit
that referenced
this pull request
Jan 14, 2026
ephraimbuddy
pushed a commit
that referenced
this pull request
Jan 16, 2026
jason810496
pushed a commit
to jason810496/airflow
that referenced
this pull request
Jan 22, 2026
jhgoebbert
pushed a commit
to jhgoebbert/airflow_Owen-CH-Leung
that referenced
this pull request
Feb 8, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
When inserting scripts into Dockerfiles, the file write function is currently called inside a loop, causing the file to be written line by line.
Proposal
Move the file write operation outside the loop so the content is written only once. This reduces unnecessary I/O operations and improves execution time.