Skip to content

Conversation

@chirodip98
Copy link
Contributor

@chirodip98 chirodip98 commented Jan 17, 2026

@boring-cyborg boring-cyborg bot added area:providers provider:google Google (including GCP) related issues labels Jan 17, 2026
@chirodip98
Copy link
Contributor Author

I would need some assistance to run System Tests for DataFusion , As I dont have any running instance.

@chirodip98
Copy link
Contributor Author

@MaksYermak Kindly review : )

@jscheffl
Copy link
Contributor

Or @VladaZakharova ?

Copy link
Contributor

@shahar1 shahar1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I prefer first to revert the original PR (#60701) to fix it quickly, reopen the original issue, and then you could solve it in this one.
After reverting, this will create conflicts the current PR.
I'm aware that it's a bit extra work for you, but I think that it's better to start from a more stable state.

I'll cancel the "Request changes" once the original PR is reverted.

@chirodip98
Copy link
Contributor Author

Sure @shahar1 once the revert is done I will start working on the same !

@shahar1
Copy link
Contributor

shahar1 commented Jan 17, 2026

Sure @shahar1 once the revert is done I will start working on the same !

Sounds great.
To avoid confusion - I'll reopen the original issue and assign you to that.

@shahar1 shahar1 self-requested a review January 17, 2026 16:38
@shahar1
Copy link
Contributor

shahar1 commented Jan 17, 2026

Sure @shahar1 once the revert is done I will start working on the same !

Sounds great. To avoid confusion - I'll reopen the original issue and assign you to that.

@chirodip98 You're good to go and start implementing.

Maintainers - please do not merge this PR unless we're certain that it passes the system tests successfully.

@chirodip98
Copy link
Contributor Author

Sure. I will start working, However I need some guidance on running the system tests. As I don't have any Data fusion instance , how to get around this?
@shahar1

@chirodip98
Copy link
Contributor Author

chirodip98 commented Jan 18, 2026

report.html

I need help with the System tests!!!

@shahar1
Copy link
Contributor

shahar1 commented Jan 18, 2026

report.html

I need help with the System tests!!!

Hey, please allow some time to Google's provider team to reply - it might take some time (as it is still weekend), and there's no guarantee that it will happen fast or anytime soon. In general, I'd kindly ask not to rush maintainers or other stakeholders to review your PRs - people maintain this project voluntarily, and their time and attention should be respected.
You're always welcome to start working on other PRs, there are many good first issues to work on.

@VladaZakharova
Copy link
Contributor

report.html
I need help with the System tests!!!

Hey, please allow some time to Google's provider team to reply - it might take some time (as it is still weekend), and there's no guarantee that it will happen fast or anytime soon. In general, I'd kindly ask not to rush maintainers or other stakeholders to review your PRs - people maintain this project voluntarily, and their time and attention should be respected. You're always welcome to start working on other PRs, there are many good first issues to work on.

thank you, @shahar1
I think your comment is a really helpful point for all the starting developers in the Community :)

@chirodip98
thank you for your PR, but I want to remind you that there are a lot of opened issues in the Community and Composer for us. When creating a PR it is mostly the responsibility of the owner of the PR to verify that the changes are working correctly. Although I am happy to help you testing them, there is a list of priorities
I will try to run your changes this week to verify is it is working as expected

@shahar1 shahar1 changed the title fix: handling start_pipeline() when response is None / Invalid Handle start_pipeline() when response is None / Invalid Jan 22, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area:providers provider:google Google (including GCP) related issues

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Airflow Datafusion Hook: Bug in CDAP Program Start Status Validation & API Usage

4 participants