-
Notifications
You must be signed in to change notification settings - Fork 16.3k
Handle start_pipeline() when response is None / Invalid #60688
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
|
I would need some assistance to run System Tests for DataFusion , As I dont have any running instance. |
|
@MaksYermak Kindly review : ) |
|
Or @VladaZakharova ? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I prefer first to revert the original PR (#60701) to fix it quickly, reopen the original issue, and then you could solve it in this one.
After reverting, this will create conflicts the current PR.
I'm aware that it's a bit extra work for you, but I think that it's better to start from a more stable state.
I'll cancel the "Request changes" once the original PR is reverted.
|
Sure @shahar1 once the revert is done I will start working on the same ! |
Sounds great. |
@chirodip98 You're good to go and start implementing. Maintainers - please do not merge this PR unless we're certain that it passes the system tests successfully. |
|
Sure. I will start working, However I need some guidance on running the system tests. As I don't have any Data fusion instance , how to get around this? |
|
I need help with the System tests!!! |
Hey, please allow some time to Google's provider team to reply - it might take some time (as it is still weekend), and there's no guarantee that it will happen fast or anytime soon. In general, I'd kindly ask not to rush maintainers or other stakeholders to review your PRs - people maintain this project voluntarily, and their time and attention should be respected. |
thank you, @shahar1 @chirodip98 |
closes: #50387
Refference : https://cdap.atlassian.net/wiki/spaces/DOCS/pages/477560983/Lifecycle+Microservices#Start-a-Program