(feat): add HTTP request customization parameters to SnowflakeSqlApiHook#60689
Merged
eladkal merged 5 commits intoapache:mainfrom Jan 21, 2026
Merged
(feat): add HTTP request customization parameters to SnowflakeSqlApiHook#60689eladkal merged 5 commits intoapache:mainfrom
SnowflakeSqlApiHook#60689eladkal merged 5 commits intoapache:mainfrom
Conversation
|
Congratulations on your first Pull Request and welcome to the Apache Airflow community! If you have any issues or are unsure about any anything please check our Contributors' Guide (https://github.com/apache/airflow/blob/main/contributing-docs/README.rst)
|
jscheffl
approved these changes
Jan 17, 2026
Contributor
jscheffl
left a comment
There was a problem hiding this comment.
Looks reasonable for me but as I have no Snowflake experience I'd ask some additional pair of eyes
eladkal
reviewed
Jan 17, 2026
providers/snowflake/src/airflow/providers/snowflake/hooks/snowflake_sql_api.py
Outdated
Show resolved
Hide resolved
HyunWooZZ
commented
Jan 17, 2026
providers/snowflake/src/airflow/providers/snowflake/hooks/snowflake_sql_api.py
Outdated
Show resolved
Hide resolved
HyunWooZZ
commented
Jan 17, 2026
providers/snowflake/tests/unit/snowflake/hooks/test_snowflake_sql_api.py
Outdated
Show resolved
Hide resolved
2 tasks
potiuk
approved these changes
Jan 20, 2026
SnowflakeSqlApiHook
SnowflakeSqlApiHookSnowflakeSqlApiHook
eladkal
approved these changes
Jan 21, 2026
|
Awesome work, congrats on your first merged pull request! You are invited to check our Issue Tracker for additional contributions. |
suii2210
pushed a commit
to suii2210/airflow
that referenced
this pull request
Jan 26, 2026
…Hook` (apache#60689) * Add http_request_kwargs, aiohttp_session_kwargs, and aiohttp_request_kwargs parameters to allow customization of HTTP requests for both sync and async operations.
85 tasks
shreyas-dev
pushed a commit
to shreyas-dev/airflow
that referenced
this pull request
Jan 29, 2026
…Hook` (apache#60689) * Add http_request_kwargs, aiohttp_session_kwargs, and aiohttp_request_kwargs parameters to allow customization of HTTP requests for both sync and async operations.
jhgoebbert
pushed a commit
to jhgoebbert/airflow_Owen-CH-Leung
that referenced
this pull request
Feb 8, 2026
…Hook` (apache#60689) * Add http_request_kwargs, aiohttp_session_kwargs, and aiohttp_request_kwargs parameters to allow customization of HTTP requests for both sync and async operations.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR enhances the Snowflake SQL API hook by consistently applying the http_timeout_seconds parameter to both synchronous and asynchronous HTTP requests.
Also it updates retry logic to consider asyncio.TimeoutError retryable.
Was generative AI tooling used to co-author this PR?
Details
Tests
Sync retry behavior is already extensively covered by existing tests..
So, this PR adds coverage for timeout propagation and async timeout retries.