-
Notifications
You must be signed in to change notification settings - Fork 16.3k
Logout the user when the token expires #60781
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
I think this also covers the "the encryption/signing key has changed" for local development installs, right? |
providers/keycloak/src/airflow/providers/keycloak/auth_manager/keycloak_auth_manager.py
Outdated
Show resolved
Hide resolved
f60fe20 to
d00ba97
Compare
providers/keycloak/src/airflow/providers/keycloak/auth_manager/keycloak_auth_manager.py
Outdated
Show resolved
Hide resolved
Yep |
48a3a80 to
ec29c5c
Compare
4cbbcc7 to
ef1bb98
Compare
|
@vincbeck, what's the lifespan of an jwt token today? One concern here is having users to login very frequently |
It defaults to configuration for both execution and public api have different values. So admins should be able to change according to their security concerns and user behavior
For execution api,
|
By default it is one day, but it is a config so you can change it. Note that this PR does not change that. Today, after one day your token is no longer valid. The only difference is today you get alerts all over the UI because you no longer have valid credentials. This PR changes that and logs you out |
bugraoz93
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks Vincent!
Ah! that's great! This makes sense |
airflow-core/tests/unit/api_fastapi/auth/middlewares/test_refresh_token.py
Outdated
Show resolved
Hide resolved
ef1bb98 to
e58ab2f
Compare
Resolves #59359
There are 2 scenarios:
In both cases, the user as a invalid token and is should no longer be considered as logged-in.
Was generative AI tooling used to co-author this PR?
{pr_number}.significant.rstor{issue_number}.significant.rst, in airflow-core/newsfragments.