Skip to content

Fix KeyError when k8s omits optional reason field in container waiting status #60527 #60805

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
jscheffl merged 1 commit into from
Feb 5, 2026
Merged

Fix KeyError when k8s omits optional reason field in container waiting status #60527 #60805

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 5 additions & 6 deletions ...f/kubernetes/src/airflow/providers/cncf/kubernetes/executors/kubernetes_executor_utils.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -260,14 +260,13 @@ def process_status(
for container_status in container_statuses_to_check:
container_status_state = container_status["state"]
if "waiting" in container_status_state:
waiting_reason = container_status_state["waiting"].get("reason")
waiting_message = container_status_state["waiting"].get("message")
if (
container_status_state["waiting"]["reason"]
waiting_reason
in self.kube_config.worker_pod_pending_fatal_container_state_reasons
):
if (
container_status_state["waiting"]["reason"] == "ErrImagePull"
and container_status_state["waiting"]["message"] == "pull QPS exceeded"
):
if waiting_reason == "ErrImagePull" and waiting_message == "pull QPS exceeded":
continue
key = annotations_to_key(annotations=annotations)
task_key_str = (
Expand All @@ -277,7 +276,7 @@ def process_status(
"Event: %s has container %s with fatal reason %s, task: %s",
pod_name,
container_status["name"],
container_status_state["waiting"]["reason"],
waiting_reason,
task_key_str,
)
self.watcher_queue.put(
Expand Down
20 changes: 20 additions & 0 deletions providers/cncf/kubernetes/tests/unit/cncf/kubernetes/executors/test_kubernetes_executor.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1749,6 +1749,26 @@ def assert_watcher_queue_called_once_with_state(self, state):
False,
id="OtherReasons",
),
pytest.param(
{
"status": {
"startTime": "2020-05-12T03:49:57Z",
"containerStatuses": [
{
"name": "base",
"state": {"waiting": {}}, # No "reason" key - optional per K8s API spec
"lastState": {},
"ready": False,
"restartCount": 0,
"image": "dockerhub.com/apache/airflow:latest",
"imageID": "",
}
],
}
},
False,
id="MissingReason",
),
],
)
def test_process_status_pending(self, raw_object, is_watcher_queue_called):
Expand Down