Skip to content

Comments

Default logical_date to now in airflowctl dagrun trigger to match UI behavior#61047

Merged
dheerajturaga merged 2 commits intoapache:mainfrom
dheerajturaga:bugfix/airflowctl-default-logical-date
Jan 30, 2026
Merged

Default logical_date to now in airflowctl dagrun trigger to match UI behavior#61047
dheerajturaga merged 2 commits intoapache:mainfrom
dheerajturaga:bugfix/airflowctl-default-logical-date

Conversation

@dheerajturaga
Copy link
Member

When triggering DAG runs via airflowctl without specifying --logical-date, the
parameter now defaults to the current timestamp instead of None. This aligns
with the Airflow UI behavior where the trigger form pre-populates logical_date
with the current time, providing a more intuitive user experience.

…behavior

  When triggering DAG runs via airflowctl without specifying --logical-date, the
  parameter now defaults to the current timestamp instead of None. This aligns
  with the Airflow UI behavior where the trigger form pre-populates logical_date
  with the current time, providing a more intuitive user experience.
Copy link
Contributor

@kalluripradeep kalluripradeep left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good improvement for CLI/UI consistency! This makes airflowctl more intuitive.

Minor suggestion:
Consider adding a test case to verify this default behavior:

def test_dagrun_trigger_defaults_logical_date():
    # Test that logical_date defaults to current time when not specified
    ...

This would prevent regression if the behaviour changes in the future.

Copy link
Contributor

@amoghrajesh amoghrajesh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Makes sense, @bugraoz93?

Copy link
Contributor

@bugraoz93 bugraoz93 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR! Looks great! One small nit added as a comment. I assume it shouldn't impact the test part andis easy to change, but it can even be follow up to be honest

@dheerajturaga dheerajturaga merged commit 9d61f74 into apache:main Jan 30, 2026
81 checks passed
sanchalitorpe-source pushed a commit to sanchalitorpe-source/airflow that referenced this pull request Jan 30, 2026
…behavior (apache#61047)

* Default logical_date to now in airflowctl dagrun trigger to match UI behavior

  When triggering DAG runs via airflowctl without specifying --logical-date, the
  parameter now defaults to the current timestamp instead of None. This aligns
  with the Airflow UI behavior where the trigger form pre-populates logical_date
  with the current time, providing a more intuitive user experience.

* Add tests
morelgeorge pushed a commit to morelgeorge/airflow that referenced this pull request Feb 1, 2026
…behavior (apache#61047)

* Default logical_date to now in airflowctl dagrun trigger to match UI behavior

  When triggering DAG runs via airflowctl without specifying --logical-date, the
  parameter now defaults to the current timestamp instead of None. This aligns
  with the Airflow UI behavior where the trigger form pre-populates logical_date
  with the current time, providing a more intuitive user experience.

* Add tests
shashbha14 pushed a commit to shashbha14/airflow that referenced this pull request Feb 2, 2026
…behavior (apache#61047)

* Default logical_date to now in airflowctl dagrun trigger to match UI behavior

  When triggering DAG runs via airflowctl without specifying --logical-date, the
  parameter now defaults to the current timestamp instead of None. This aligns
  with the Airflow UI behavior where the trigger form pre-populates logical_date
  with the current time, providing a more intuitive user experience.

* Add tests
jason810496 pushed a commit to abhijeets25012-tech/airflow that referenced this pull request Feb 3, 2026
…behavior (apache#61047)

* Default logical_date to now in airflowctl dagrun trigger to match UI behavior

  When triggering DAG runs via airflowctl without specifying --logical-date, the
  parameter now defaults to the current timestamp instead of None. This aligns
  with the Airflow UI behavior where the trigger form pre-populates logical_date
  with the current time, providing a more intuitive user experience.

* Add tests
jhgoebbert pushed a commit to jhgoebbert/airflow_Owen-CH-Leung that referenced this pull request Feb 8, 2026
…behavior (apache#61047)

* Default logical_date to now in airflowctl dagrun trigger to match UI behavior

  When triggering DAG runs via airflowctl without specifying --logical-date, the
  parameter now defaults to the current timestamp instead of None. This aligns
  with the Airflow UI behavior where the trigger form pre-populates logical_date
  with the current time, providing a more intuitive user experience.

* Add tests
choo121600 pushed a commit to choo121600/airflow that referenced this pull request Feb 22, 2026
…behavior (apache#61047)

* Default logical_date to now in airflowctl dagrun trigger to match UI behavior

  When triggering DAG runs via airflowctl without specifying --logical-date, the
  parameter now defaults to the current timestamp instead of None. This aligns
  with the Airflow UI behavior where the trigger form pre-populates logical_date
  with the current time, providing a more intuitive user experience.

* Add tests
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants