Skip to content

Fix aria-label for TriggerDAGButton to use correct translation key #61117

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
choo121600 merged 2 commits into from
Jan 27, 2026
Merged

Fix aria-label for TriggerDAGButton to use correct translation key #61117

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
76de91a
Fix aria-label for TriggerDAGButton to use correct translation key
choo121600 Jan 27, 2026
56a7956
Fix e2e test label
choo121600 Jan 27, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions airflow-core/src/airflow/ui/src/components/TriggerDag/TriggerDAGButton.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -93,7 +93,7 @@ export const TriggerDAGButton = ({
<Menu.Root>
<Menu.Trigger asChild>
<Button
aria-label={translate("triggerDag.button")}
aria-label={translate("triggerDag.title")}
colorPalette="brand"
size="md"
variant={variant}
Expand Down Expand Up @@ -130,7 +130,7 @@ export const TriggerDAGButton = ({
<Tooltip content={translate("triggerDag.button")} disabled={withText}>
{withText ? (
<Button
aria-label={translate("triggerDag.button")}
aria-label={translate("triggerDag.title")}
colorPalette="brand"
onClick={handleNormalTrigger}
size="md"
Expand All @@ -141,7 +141,7 @@ export const TriggerDAGButton = ({
</Button>
) : (
<IconButton
aria-label={translate("triggerDag.button")}
aria-label={translate("triggerDag.title")}
colorPalette="brand"
onClick={onOpen}
size="md"
Expand Down
2 changes: 1 addition & 1 deletion airflow-core/src/airflow/ui/tests/e2e/pages/BackfillPage.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -75,7 +75,7 @@ export class BackfillPage extends BasePage {

public constructor(page: Page) {
super(page);
this.triggerButton = page.locator('button[aria-label="Trigger"]:has-text("Trigger")');
this.triggerButton = page.locator('button[aria-label="Trigger Dag"]:has-text("Trigger")');
this.backfillModeRadio = page.locator('label:has-text("Backfill")');
this.backfillFromDateInput = page.locator('input[type="datetime-local"]').first();
this.backfillToDateInput = page.locator('input[type="datetime-local"]').nth(1);
Expand Down
2 changes: 1 addition & 1 deletion airflow-core/src/airflow/ui/tests/e2e/pages/DagsPage.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -46,7 +46,7 @@ export class DagsPage extends BasePage {

public constructor(page: Page) {
super(page);
this.triggerButton = page.locator('button[aria-label="Trigger"]:has-text("Trigger")');
this.triggerButton = page.locator('button[aria-label="Trigger Dag"]:has-text("Trigger")');
this.confirmButton = page.locator('button:has-text("Trigger")').nth(1);
this.stateElement = page.locator('*:has-text("State") + *').first();
this.paginationNextButton = page.locator('[data-testid="next"]');
Expand Down
Loading