Skip to content

Comments

Update msgraph.py get_host #61158

Closed
morelgeorge wants to merge 1 commit intoapache:mainfrom
morelgeorge:patch-1
Closed

Update msgraph.py get_host #61158
morelgeorge wants to merge 1 commit intoapache:mainfrom
morelgeorge:patch-1

Conversation

@morelgeorge
Copy link
Contributor

Description of issue
Calling the Power BI operator consistently resulted in the following error:

Request URL is missing an http:// or https:// protocol.

From the DAG logs I discovered that the host URL was parsed incorrectly. The resolved host value looked like this:

None:/ https://api.powerbi.com

Because of this malformed host string, all outgoing requests failed with the protocol‑missing error.

Solution
I updated the OR condition in the get_host method inside msgraph.py (within the hooks folder).
The updated logic correctly handles the provided host URL (https://api.powerbi.com), ensuring that it is parsed and returned properly.

Testing
After modifying the OR condition I did a testing directly in our Airflow Test instance.

  • The connection to Power BI via its Airflow operators works as expected.
  • In our Airflow instance, the provider now operates correctly without triggering the protocol error.

Replaced the OR statement which has not been working correctly with PowerBI.
@morelgeorge morelgeorge requested a review from dabla as a code owner January 28, 2026 07:54
@boring-cyborg
Copy link

boring-cyborg bot commented Jan 28, 2026

Congratulations on your first Pull Request and welcome to the Apache Airflow community! If you have any issues or are unsure about any anything please check our Contributors' Guide (https://github.com/apache/airflow/blob/main/contributing-docs/README.rst)
Here are some useful points:

  • Pay attention to the quality of your code (ruff, mypy and type annotations). Our prek-hooks will help you with that.
  • In case of a new feature add useful documentation (in docstrings or in docs/ directory). Adding a new operator? Check this short guide Consider adding an example DAG that shows how users should use it.
  • Consider using Breeze environment for testing locally, it's a heavy docker but it ships with a working Airflow and a lot of integrations.
  • Be patient and persistent. It might take some time to get a review or get the final approval from Committers.
  • Please follow ASF Code of Conduct for all communication including (but not limited to) comments on Pull Requests, Mailing list and Slack.
  • Be sure to read the Airflow Coding style.
  • Always keep your Pull Requests rebased, otherwise your build might fail due to changes not related to your commits.
    Apache Airflow is a community-driven project and together we are making it better 🚀.
    In case of doubts contact the developers at:
    Mailing List: dev@airflow.apache.org
    Slack: https://s.apache.org/airflow-slack

@dabla
Copy link
Contributor

dabla commented Jan 28, 2026

There is already another PR open for this issue

@morelgeorge
Copy link
Contributor Author

Thank you, I did not notice that. I see the logic is the same. We can close this PR.

@dabla
Copy link
Contributor

dabla commented Jan 29, 2026

Thank you, I did not notice that. I see the logic is the same. We can close this PR.

No worries, there a lot of PR’s also ;-)
Thank you for the effort.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants