Closed
Conversation
Replaced the OR statement which has not been working correctly with PowerBI.
|
Congratulations on your first Pull Request and welcome to the Apache Airflow community! If you have any issues or are unsure about any anything please check our Contributors' Guide (https://github.com/apache/airflow/blob/main/contributing-docs/README.rst)
|
Contributor
|
There is already another PR open for this issue |
Contributor
Author
|
Thank you, I did not notice that. I see the logic is the same. We can close this PR. |
Contributor
No worries, there a lot of PR’s also ;-) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of issue
Calling the Power BI operator consistently resulted in the following error:
From the DAG logs I discovered that the host URL was parsed incorrectly. The resolved host value looked like this:
Because of this malformed host string, all outgoing requests failed with the protocol‑missing error.
Solution
I updated the OR condition in the get_host method inside msgraph.py (within the hooks folder).
The updated logic correctly handles the provided host URL (https://api.powerbi.com), ensuring that it is parsed and returned properly.
Testing
After modifying the OR condition I did a testing directly in our Airflow Test instance.